Only add Lightbulb service if state is also present. This should fix …

…#1
itavero · Jul 5, 2020 · 42f9d81 · 42f9d81
1 parent 93e60b4
commit 42f9d81
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,10 @@ and after the project will apply [Semantic Versioning](https://semver.org/spec/v
 
 - README now mentions how to run the "development" version.
 
+### Fixed
+
+- Hue Dimmer Switch appears as a light bulb ([#1](https://github.com/itavero/homebridge-z2m/issues/1))
+
 ## [0.0.3][] - 2020-07-01
 ### Added
 

diff --git a/src/platformAccessory.ts b/src/platformAccessory.ts
@@ -248,10 +248,13 @@ export class Zigbee2mqttAccessory {
       case 'color_temp':
       case 'color':
       {
-        this.removeOtherServicesUsingKey('state');
-        const wrapper = new LightbulbServiceWrapper(this.getOrAddService(this.platform.Service.Lightbulb),
-          this.platform.Characteristic, this.publishSet.bind(this));
-        this.addService(wrapper, state, handledKeys);
+        if (state === undefined || state.has('state')) {
+          // Only add a light bulb if the `state` is also available.
+          this.removeOtherServicesUsingKey('state');
+          const wrapper = new LightbulbServiceWrapper(this.getOrAddService(this.platform.Service.Lightbulb),
+            this.platform.Characteristic, this.publishSet.bind(this));
+          this.addService(wrapper, state, handledKeys);
+        }
         break;
       }
       case 'position':