Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Release v1.9.1 seems broken #535

Closed
itavero opened this issue Sep 30, 2022 · 3 comments
Closed

[Bug] Release v1.9.1 seems broken #535

itavero opened this issue Sep 30, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@itavero
Copy link
Owner

itavero commented Sep 30, 2022

After updating from v1.9.0 to v1.9.1 of this plugin, all accessories showed up as "Unsupported" in my Home.app on iOS 16.

Reverting back to v1.9.0 got back all my accessories.

Need to figure out what got broken in order to release future versions of the plugin.

@itavero itavero added the bug Something isn't working label Sep 30, 2022
@itavero itavero self-assigned this Sep 30, 2022
@itavero
Copy link
Owner Author

itavero commented Sep 30, 2022

Strange that I did not notice this issue while running it on my Mac during development. 🤔

@itavero
Copy link
Owner Author

itavero commented Oct 1, 2022

In the logs I spotted this:

[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Restoring accessory: light_hobbyroom (0x00178801033bbc80)
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Exception occurred when creating services for lights/hobby/pendant: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Restoring accessory: light_office (0x0017880100d9b08f)
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Exception occurred when creating services for lights/office/pendant: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Restoring accessory: light_guestbedroom (0x00178801026f884a)
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Exception occurred when creating services for lights/guestbedroom/pendant: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_officedesk_right (0x0017880106117ff9)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/office/desk_right: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_officedesk_left (0x0017880106117b15)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/office/desk_left: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_livingroom_sinnerlig (0x0017880100fca647)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/livingroom/sinnerlig: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_kitchen (0x0017880100d9b1cb)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/kitchen/pendant: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_frontdoor (0x00178801026f88da)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/outside/frontdoor: TypeError: Cannot read properties of undefined (reading 'additionalConfig')

@itavero
Copy link
Owner Author

itavero commented Oct 1, 2022

In several locations, I passed accessory.isPropertyExcluded as a "callback", but I forgot to bind it to accessory, causing the actual call to fail.
This did apparently also happen on my development machine, but somehow I did not notice this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant