Allow alternative services to be selected #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 50.36% 53.30% +2.94%
==========================================
Files 23 36 +13
Lines 1938 2088 +150
Branches 509 534 +25
==========================================
+ Hits 976 1113 +137
+ Misses 509 507 -2
- Partials 453 468 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…Motion Sensor instead of Occupancy Sensor.
itavero
changed the title
|
🆗 Published SonarCloud and code coverage data. |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out some things on this branch to allow for configuration that is specific to a converter, which would allow users to configure certain converters to behave differently (i.e. expose a different services, like an Outlet instead of a Switch).
Hopefully in the end this will provide a solution for #45, #279, #380, #422 and possibly other issues/requests I'm forgetting here.
No promises yet, as I still feel this approach requires some polishing.
Definitely still to do:
basic_sensors.ts(information about the properties should be in the class that handles it rather than in the "creator collection")