Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isDeviceDefinition and improve check in createOrUpdateAccessory #797

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

itavero
Copy link
Owner

@itavero itavero commented Jan 2, 2024

Relates to #794

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d19f77e) 53.44% compared to head (9d8bcf4) 53.65%.

❗ Current head 9d8bcf4 differs from pull request most recent head 454d441. Consider uploading reports for the commit 454d441 to get more accurate results

Files Patch % Lines
src/z2mModels.ts 63.63% 0 Missing and 4 partials ⚠️
src/platform.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           hotfix-on-v1.9.2     #797      +/-   ##
====================================================
+ Coverage             53.44%   53.65%   +0.20%     
====================================================
  Files                    37       37              
  Lines                  2116     2121       +5     
  Branches                541      541              
====================================================
+ Hits                   1131     1138       +7     
+ Misses                  513      512       -1     
+ Partials                472      471       -1     
Flag Coverage Δ
tests 53.65% <58.33%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 2, 2024

@itavero itavero merged commit 7f3454a into hotfix-on-v1.9.2 Jan 2, 2024
3 checks passed
@itavero itavero deleted the fix-is-device-definition branch January 2, 2024 19:34
Copy link
Contributor

github-actions bot commented Jan 2, 2024

❌ Failed to run SonarCloud and/or code coverage step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant