Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push fails when --if-changed flag is provided using a zip file as the source. #228

Open
rsethc opened this issue Dec 17, 2021 · 1 comment

Comments

@rsethc
Copy link

rsethc commented Dec 17, 2021

Using the --if-changed flag against a zip archive causes Butler to fail, whereas simply omitting the flag results in a successful push. While I suspect it's specific to zip archives (due to the "lstat ...: not a directory" text) I have not done further testing to prove that. This particular zip archive contains, at the top level, no files and one folder 'built' which contains game files within it (I can provide the archive itself, if this would help).

> Comparing against previous build...
checking for differences: lstat game.zip/built: not a directory
The command '/bin/sh -c butler push game.zip glassblade/kringle-logistics:windows --if-changed' returned a non-zero code: 1

Perhaps the error text itself is originating from here:

return errors.Wrap(err, "checking for differences")

@bend-n
Copy link

bend-n commented May 26, 2022

can confirm, had to create my own diffing system (there were issues with directorys for me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants