Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior regarding whitespace in API key #244

Open
kbieganski opened this issue Sep 28, 2022 · 0 comments
Open

Inconsistent behavior regarding whitespace in API key #244

kbieganski opened this issue Sep 28, 2022 · 0 comments

Comments

@kbieganski
Copy link

If the user specifies the API key with leading/trailing whitespace, Butler is able to push an initial build to a given target. However, during an update push, it fails with the following message:

searching for parent build signature: opening signature: htfs.Open (initial request): in conn.Connect, non-retriable error: in conn.tryConnect, got HTTP non-2XX: api.itch.io: HTTP 403: {"errors":["invalid key"]}

Seems the pushing code itself is able to deal with the whitespace (possibly by trimming it), but that does not happen for build signature retrieval.

This behavior is inconsistent and quite confusing, and there was at least one more person that encountered this issue almost two years ago (that thread is archived now). I think the whitespace should always either be trimmed or cause an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant