Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make good use of async/await rather than Promise.{resolve,then} in tests #319

Closed
fasterthanlime opened this issue Jan 5, 2016 · 2 comments
Closed

Make good use of async/await rather than Promise.{resolve,then} in tests #319

fasterthanlime opened this issue Jan 5, 2016 · 2 comments
Labels
code quality Amos is bikeshedding again
Milestone
soon

Comments

@fasterthanlime
Copy link
Collaborator

async/await is better.
@fasterthanlime fasterthanlime modified the milestones: 0.12.x, soon Jan 5, 2016
@fasterthanlime fasterthanlime added the code quality Amos is bikeshedding again label Jan 14, 2016
fasterthanlime added a commit that referenced this issue Jan 15, 2016
@fasterthanlime
💚 Fix find-upload spec, lil bit of #382 and #319
1e95ae5
@fasterthanlime
Copy link
Collaborator Author

Let's make that a more attainable objective

@fasterthanlime fasterthanlime changed the title Get rid of .then() in all specs Get rid of all setTimeout calls in specs Jan 22, 2016
@fasterthanlime
Copy link
Collaborator Author

Attainable objective attained in b2c01a0

@fasterthanlime fasterthanlime changed the title Get rid of all setTimeout calls in specs Make good use of async/await rather than Promise.{resolve,then} in tests Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Amos is bikeshedding again
Projects
None yet
Milestone
soon
Development

No branches or pull requests
1 participant
@fasterthanlime