Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itch application breaks symbolic links in tar.bz2 packages #340

Closed
fractilegames opened this issue Jan 8, 2016 · 8 comments
Closed

Itch application breaks symbolic links in tar.bz2 packages #340

fractilegames opened this issue Jan 8, 2016 · 8 comments
Milestone

Comments

@fractilegames
Copy link

I tested if my game (http://fractilegames.itch.io/lockdown-protocol) works in Itch application on Linux. It did not:

[Fri, 08 Jan 2016 17:49:45 GMT] [tasks/launch] launching '/home/mikko/.config/itch/users/60846/apps/1Ek9fCQjfFi24HDt/lockdownprotocol-1.4.1-linux64/lockdownprotocol' on 'linux' with args ''
[Fri, 08 Jan 2016 17:49:45 GMT] [tasks/launch] sh "/home/mikko/.config/itch/users/60846/apps/1Ek9fCQjfFi24HDt/lockdownprotocol-1.4.1-linux64/lockdownprotocol"
[Fri, 08 Jan 2016 17:49:45 GMT] [tasks/launch] Working directory: /home/mikko/.config/itch/users/60846/apps/1Ek9fCQjfFi24HDt/lockdownprotocol-1.4.1-linux64
[Fri, 08 Jan 2016 17:49:45 GMT] [tasks/launch] stderr: Unable to open library: lib/libopenal.so.1: file too short

The lib -directory contains symbolic links that were somehow converted into regular files during installation. The game works well if I manually extract the tar.bz2 package contents to .config/itch/users/60846/apps/1Ek9fCQjfFi24HDt -directory.

@fasterthanlime fasterthanlime added this to the soon milestone Jan 8, 2016
@fasterthanlime
Copy link
Collaborator

So it turns out it's a 7-zip bug. I'm looking into different options

@fasterthanlime fasterthanlime modified the milestones: 0.12.4, soon Jan 11, 2016
@fasterthanlime
Copy link
Collaborator

I don't feel like relying on having a 'tar' utility installed system-wide (ie. that would exclude windows and we've had .tar archive on Windows games before - or we would have to support both codepaths (extract .tar files using 7-zip, or with tar if present)), so the best bet currently seems to add tar extracting to butler.

https://github.com/itchio/butler

@fasterthanlime
Copy link
Collaborator

Fix will be included in version 0.12.4

@fasterthanlime
Copy link
Collaborator

(Next issue for you will be that the app picks up install.sh before the game itself, so it quits immediately. An easy fix would simply be to move install.sh into a scripts directory and to mention that to the human user in a README.txt file)

@fractilegames
Copy link
Author

Thanks for the heads up. I could do that or just remove the script completely.

@fasterthanlime
Copy link
Collaborator

or just remove the script completely.

Sure, that works too :) 0.12.4 is out btw, can you confirm that if you re-install the game with it, you now see symbolic links on your system?

@fractilegames
Copy link
Author

Yes, the symbolic links are preserved now!

@fasterthanlime
Copy link
Collaborator

Awesome, thanks for reporting back! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants