Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You may not unsubscribe from a store listener while the reducer is executing #846

Closed
fasterthanlime opened this issue Aug 2, 2016 · 8 comments
Closed

You may not unsubscribe from a store listener while the reducer is executing #846

fasterthanlime opened this issue Aug 2, 2016 · 8 comments

Comments

@fasterthanlime
Copy link
Collaborator

Error thrown spuriously from the chrome side. Wonder what that's about?
@fasterthanlime
Copy link
Collaborator Author

happened again:

virtualbox_archlinux_02_08_2016_19_40_00

@fasterthanlime fasterthanlime changed the title You may not unsubscribe from the store while a reducer is running You may not unsubscribe from a store listener while the reducer is executing Aug 2, 2016
@fasterthanlime
Copy link
Collaborator Author

Happens with kitch 18.4.5-canary on ArchLinux (haven't seen the bug anywhere else yet).

I'm trying to remove react-safe, see if it's causing it.

@fasterthanlime
Copy link
Collaborator Author

This sounds like a timing issue but I don't know which side is to blame! And it only happens on my ArchLinux VM.

@fasterthanlime
Copy link
Collaborator Author

Not a timing issue, see samiskin/redux-electron-store#27

@samiskin
Copy link

samiskin commented Aug 2, 2016

Yep this is 100% my fault, will get to fixing this as soon as I can, sorry!

@fasterthanlime
Copy link
Collaborator Author

@samiskin I was working on getting you an actual stack trace - still useful or no?

@samiskin
Copy link

samiskin commented Aug 2, 2016

Definitely useful, I haven't had time to reproduce and investigate yet.

@fasterthanlime
Copy link
Collaborator Author

Cool. There's no pressure - I'll pin to a version that's not affected by it so I can ship 18.5.0, and you'll have time for a good fix :)

fasterthanlime added a commit that referenced this issue Aug 2, 2016
@fasterthanlime
🐛 Pin redux-electron-store to 0.3.11 because of #846
b0d7f92
@fasterthanlime fasterthanlime mentioned this issue Aug 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samiskin @fasterthanlime