Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat: Add market view #301

Merged
merged 2 commits into from Nov 22, 2022
Merged

feat: Add market view #301

merged 2 commits into from Nov 22, 2022

Conversation

klochowicz
Copy link
Contributor

@klochowicz klochowicz commented Nov 22, 2022

Embed a TradingView bitmex XBTUSD widget inside a webview.

Note: it works on Android/iOS. Desktop platforms get a placeholder that the
functionality is not supported yet.

I've recorded in landscape, as it's much nicer for viewing charts like that 馃榿
https://user-images.githubusercontent.com/8319440/203267520-dd5b8835-12e2-4ca1-8aa9-579b5e8f081a.mov

@klochowicz
Copy link
Contributor Author

@holzeis could you please verify that it works on Android too? (I don't have the emulator working...)

@klochowicz klochowicz linked an issue Nov 22, 2022 that may be closed by this pull request
@klochowicz klochowicz self-assigned this Nov 22, 2022
@holzeis
Copy link
Collaborator

holzeis commented Nov 22, 2022

@holzeis could you please verify that it works on Android too? (I don't have the emulator working...)

It unfortunately does not work as is..

The plugin webview_flutter_android requires Android SDK version 32.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkDebugAarMetadata'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
   > The minCompileSdk (32) specified in a
     dependency's AAR metadata (META-INF/com/android/build/gradle/aar-metadata.properties)
     is greater than this module's compileSdkVersion (android-31).
     Dependency: androidx.webkit:webkit:1.5.0.
     AAR metadata file: /Users/holzeis/.gradle/caches/transforms-2/files-2.1/1e17c3cecd51956dd096ba6a3522bf2f/webkit-1.5.0/META-INF/com/android/build/gradle/aar-metadata.properties.

I'll have a look if I can fix that.

Embed a TradingView bitmex XBTUSD widget inside a webview.

Note: it works on Android/iOS. Desktop platforms get a placeholder that the
    functionality is not supported yet.
The plugin webview_flutter_android requires Android SDK version 32.
@holzeis
Copy link
Collaborator

holzeis commented Nov 22, 2022

I'll have a look if I can fix that.

This 596e0b4 increases the android sdk versions, required by webview_flutter_android. Only downside we won't be compatible with android versions lower than 19.

Copy link
Collaborator

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/flutter/plugins/tree/main/packages/webview_flutter/webview_flutter

The webview_flutter plugin seems to be the far more popular option. No need to action, but leaving it here in case we want to pick it up again after the tournament.

@klochowicz
Copy link
Contributor Author

https://github.com/flutter/plugins/tree/main/packages/webview_flutter/webview_flutter

The webview_flutter plugin seems to be the far more popular option. No need to action, but leaving it here in case we want to pick it up again after the tournament.

I should have mentioned it in the commit description - we cannot use the webview_flutter unfortunately easily the way we're doing it :( that's how I started, and could not make it work.maybe we can host the html somewhere and then we could swap the dependency, but it's not worth it this week :)

@da-kami
Copy link
Contributor

da-kami commented Nov 22, 2022

Does this mean we should merge this or not?
It works on iPhone?

@klochowicz
Copy link
Contributor Author

Does this mean we should merge this or not?
It works on iPhone?

yes, we should merge it. it works on iPhone - see the video attached.

@klochowicz
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

Build succeeded:

@bors bors bot merged commit c470d81 into main Nov 22, 2022
@bors bors bot deleted the add-market-widget branch November 22, 2022 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed TradingView XBTUSD widget in "Market" tab
3 participants