Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked Spinner #17

Merged
merged 9 commits into from Feb 14, 2015
Merged

Reworked Spinner #17

merged 9 commits into from Feb 14, 2015

Conversation

PizzaLovers007
Copy link
Contributor

Made the spinner feel more like the osu! spinner.

+Calculated the RPM as the average of the last 50 read RPM's

PizzaLovers007 and others added 9 commits February 9, 2015 17:11
Added angular velocity and angular drag
Current Issues:
- Need to handle change in direction better
- Spinning speed seems to be inaccurate
Added a “weight” to the spinner to make the RPM more like osu!

May need to tweak constants to make the spinner feel more natural.
Full implementation of a "weighted" spinner. May need to tweak some constants to make it more like osu!
Sets the RPM to the average of the last 50 velocities read by the
cursor.
@itdelatrisu
Copy link
Owner

Looks great. Thanks so much for your help!

One really insignificant thing: rpm isn't being set for the Auto/Spun-Out mods. I'll just add it to the TODO. :P

itdelatrisu added a commit that referenced this pull request Feb 14, 2015
@itdelatrisu itdelatrisu merged commit 2c59b34 into itdelatrisu:master Feb 14, 2015
itdelatrisu added a commit that referenced this pull request Feb 14, 2015
Fixed not losing any health at near-zero rotation angles.

Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
@itdelatrisu
Copy link
Owner

FPS seems to be having an effect on spinner difficulty -- it's a lot harder to spin at 60fps vs. 240fps. Could you look at it?

@PizzaLovers007
Copy link
Contributor Author

Alright I'll try to look into it this weekend

On Tuesday, March 3, 2015, Jeffrey Han notifications@github.com wrote:

FPS seems to be having an effect on spinner difficulty -- it's a lot
harder to spin at 60fps vs. 240fps. Could you look at it?


Reply to this email directly or view it on GitHub
#17 (comment).

@chong601
Copy link

chong601 commented Mar 5, 2015

It actually also affected when running opsu! at arbitrary FPS (for example 1000+FPS and yes that is possible). The spinner cannot be cleared at all even on the easiest ones.

Also, I found that even i can spin 400+ on osu!, it doesn't seem to happen on opsu! even if i spin like a madman (regardless whether the fps is 60, 120 or 240).

@itdelatrisu
Copy link
Owner

fluddokt fixed this in #37 -- thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants