Add support for gw2000+ws90 (Wittboy) parameters #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realised that the GW2000 exposes 'tempf' and 'humidity' as measured by the device itself, and this wasn't being exposed properly. Missed it because I also have an external connected to channel 1 (in addition to the ws90). Updated the default channel 1 path to reflect this as well. Also added a heatIndex function. lmk if you don't want this in and I can remove it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the parameters exposed by the GW2000 paired with a WS90 (together known as Wittboy).
It also calculates the heat index ('feels like') if we have both temperature and humidity for any of the sensors.
Sadly I don't have another Ecowitt device to test with, so I can't verify this doesn't break other stuff but it's only an additive change.
Would be nice for signalk to known the unit used for rainfall, but I can't seem to understand how to get it to do that
fixes #2