Full rebuild to support multiple providers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in other packages
|
Once this is merged we can tag it as 1.0.0 and push up to Workflow. |
|
@rwitchell I've added you as a reviewer too seeing as you were looking for Spout support. |
Git wouldn't pick up the different between Readme.md and README.md so had to spread a bigger name change across multiple commits so it'd pick up the capitalisation change
|
🎈 🎆 🍾 🏆 😢 goodbye our first pull request. |
|
Restored the develop branch as it's nice to have around :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite adds a Silex Service Provider along with support for PHPExcel and Spout.
Note that Spout and PHPExcel aren't like for like, Spout has a lot less formatting options but is significantly more performant than PHPExcel. If you need a huge spreadsheet with minimal formatting, use Spout. If you need fancy formatting then use PHPExcel.
I've also added some tests but these could be further improved beyond what they currently do.