Support accepting additional content types #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrbel
approved these changes
Oct 23, 2019
blazekadam
requested changes
Oct 23, 2019
apistrap/operation_wrapper.py
Outdated
| return ( | ||
| body_param.name, | ||
| resolve_fw_decl(self._wrapped_function, body_param.annotation), | ||
| accepts_decorator.mimetypes if accepts_decorator else ("application/json",), |
There was a problem hiding this comment.
2nd time defining the default ("application/json",), is it necessary?
apistrap/operation_wrapper.py
Outdated
| @@ -388,7 +383,7 @@ def _get_responses_from_raises(self) -> Generator[Tuple[Type[Model], int, Respon | |||
|
|
|||
| yield ErrorResponse, code, ResponseData(item.description) | |||
|
|
|||
| def _get_request_body_parameter(self) -> Union[Tuple[str, Type], Tuple[None, None]]: | |||
| def _get_request_body_parameter(self) -> Union[Tuple[str, Type, Optional[Sequence[str]]], Tuple[None, None, None]]: | |||
| """ | |||
| Get the name and type of the parameter used to pass the request body to the view handler. | |||
There was a problem hiding this comment.
Suggested change
| Get the name and type of the parameter used to pass the request body to the view handler. | |
| Get the name, type and accepted mime types | |
| of the parameter used to pass the request body to the view handler. |
blazekadam
reviewed
Oct 23, 2019
| }, | ||
| "required": ["string_field", "int_field"] | ||
| } | ||
|
|
There was a problem hiding this comment.
I am not sure... is the case where you pass an invalid json tested?
blazekadam
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.