Better handling of security schemes and enforcers #99

janbuchar · 2019-10-04T08:09:11Z

The main benefit here is that we can pass the Request object to AioHTTP security enforcers. Not being able to do that rendered them mostly unusable.

blazekadam

Its alright but we should really look into #79 .

blazekadam · 2019-10-04T11:25:43Z

apistrap/aiohttp.py

+                return
+            except Exception as e:
+                error = e
+        else:


thumbs up for for-else

Better handling of security schemes and enforcers

46a21ca

janbuchar requested a review from blazekadam October 4, 2019 08:09

blazekadam approved these changes Oct 4, 2019

View reviewed changes

apistrap/aiohttp.py

return

except Exception as e:

error = e

else:

Copy link

Contributor

blazekadam Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbs up for for-else

janbuchar merged commit 14e3d83 into dev Oct 7, 2019

janbuchar deleted the better-security-scheme-handling branch October 7, 2019 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better handling of security schemes and enforcers #99

Better handling of security schemes and enforcers #99

janbuchar commented Oct 4, 2019 •

edited

blazekadam left a comment •

edited

blazekadam Oct 4, 2019

Better handling of security schemes and enforcers #99

Better handling of security schemes and enforcers #99

Conversation

janbuchar commented Oct 4, 2019 • edited

blazekadam left a comment • edited

Choose a reason for hiding this comment

blazekadam Oct 4, 2019

Choose a reason for hiding this comment

janbuchar commented Oct 4, 2019 •

edited

blazekadam left a comment •

edited