By default always set to change permissions after edit. Add hidden pr…

…operty editor.upload.permissions.change. Former-commit-id: 25eb36ea95dbc101a16ddc8a4264957a39a4fb68
iterate-ch · Nov 1, 2013 · e1de1ad · e1de1ad
1 parent 9abf751
commit e1de1ad
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/source/ch/cyberduck/core/Preferences.java b/source/ch/cyberduck/core/Preferences.java
@@ -341,6 +341,7 @@ protected void setDefaults() {
 
         defaults.put("editor.odb.enable", String.valueOf(false));
         defaults.put("editor.upload.temporary", String.valueOf(true));
+        defaults.put("editor.upload.permissions.change", String.valueOf(true));
 
         defaults.put("filetype.text.regex",
                 ".*\\.txt|.*\\.cgi|.*\\.htm|.*\\.html|.*\\.shtml|.*\\.xml|.*\\.xsl|.*\\.php|.*\\.php3|" +

diff --git a/source/ch/cyberduck/core/editor/AbstractEditor.java b/source/ch/cyberduck/core/editor/AbstractEditor.java
@@ -239,10 +239,9 @@ public TransferAction action(final Session<?> session, final boolean resumeReque
 
                 @Override
                 public AbstractUploadFilter filter(final Session<?> session, final TransferAction action) {
-                    final AbstractUploadFilter filter = super.filter(session, action);
-                    filter.setOptions(new UploadFilterOptions().withTemporary(
-                            Preferences.instance().getBoolean("editor.upload.temporary")));
-                    return filter;
+                    return super.filter(session, action).withOptions(new UploadFilterOptions()
+                            .withTemporary(Preferences.instance().getBoolean("editor.upload.temporary"))
+                            .withPermission(Preferences.instance().getBoolean("editor.upload.permissions.change")));
                 }
             };
             final SingleTransferWorker worker

diff --git a/source/ch/cyberduck/core/transfer/upload/AbstractUploadFilter.java b/source/ch/cyberduck/core/transfer/upload/AbstractUploadFilter.java
@@ -77,8 +77,9 @@ public AbstractUploadFilter(final SymlinkResolver symlinkResolver, final Session
         this.attribute = session.getFeature(Attributes.class).withCache(cache);
     }
 
-    public void setOptions(final UploadFilterOptions options) {
+    public AbstractUploadFilter withOptions(final UploadFilterOptions options) {
         this.options = options;
+        return this;
     }
 
     @Override