Recursive search displaying folders not containing files matching the pattern

[tsvng]

Describe the bug
When using the recursive search feature to find files matching a certain pattern, it will display folders that DO NOT contain any files matching the pattern. When expanding these folders that do not contain files matching the pattern, it will not list any files (essentially act as an empty folder).

To Reproduce
Steps to reproduce the behavior:

1. Go to a folder containing several directories
2. Click on the search bar and enter a pattern that will hit a file within at least one, but not all of the child directories.
3. Hit 'return' on the keyboard to enact the recursive search.
4. See error where folders that do not contain any files matching the pattern will be listed.

Expected behavior
Per Cyberduck Docs
Only files matching the search or folders with containing files matching the pattern will be displayed in the browser.

Desktop (please complete the following information):

• OS: macOS Monterey v12.5.1
• Cyberduck Version 8.5.1 (38745)

Additional context
Used to work as expected until I updated to the latest version.

[dkocher]

Please let me know for what protocols you can reproduce this.

[tsvng]

This is when using Amazon S3 protocol.

[porg]

• Docs:

  Only files matching the search or folders with containing files matching the pattern will be displayed in the browser.

  • 👍 Usability wise in an recursive outline view (a.k.a. "tree view") it makes sense to hide folders which have no matches in any of their deeper descendants. Those would be just an endless "orphan line" (folder, containing folder, containing folder, … containing folder which contains nothing that matched).
  • 👉 Whereas when filtering in the current directory only or in my proposed sticky filtered browsing the descendants should not matter at all!
    • Filtering, whether inclusive or exclusive should only apply on the current level!
    • Real orphan directories show up, unless a negative query operator) results them to get hidden.
    • And also directories, which would be empty if queried recursively, should be shown. Because the search is not recursive, but only applies to the active directory. Just wanted to mention that explicitly. That this is not changed into the wrong direction.

• Today I also proposed Search query operator / slash which matches in directory names only #14182

  • @tsvng : Would this more differentiated search option help your in this your use case or other use cases?
  • @dkocher What do you say?
  • All: Feel free to tune in over there, if interested.

[dkocher]

• 👍 Usability wise in an recursive outline view (a.k.a. "tree view") it makes sense to hide folders which have no matches in any of their deeper descendants. Those would be just an endless "orphan line" (folder, containing folder, containing folder, … containing folder which contains nothing that matched).

Fixed with #14183.

[porg]

1. Glad to read about the fix.

2. I'd appreciate a reaction to this my statement/inquiry:

• 👉 Whereas when filtering in the current directory only or in my proposed sticky filtered browsing the descendants should not matter at all!

• For the proposed sticky filtered browsing this is just to keep in mind.
• For filtering in the current directory only: Is this working as described?