Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add menu item to request files for protocols that support upload share links #13427

Merged
merged 12 commits into from Jun 8, 2022
Merged

Add menu item to request files for protocols that support upload share links #13427

merged 12 commits into from Jun 8, 2022

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Jun 2, 2022

No description provided.

@dkocher dkocher added this to the 8.4.0 milestone Jun 2, 2022
@dkocher dkocher requested a review from a team as a code owner June 2, 2022 10:05
@dkocher dkocher linked an issue Jun 2, 2022 that may be closed by this pull request
Add menu item to request files for protocols that support upload share links #13426
Closed
@dkocher dkocher changed the title Feature/gh 13426 Add menu item to request files for protocols that support upload share links Jun 2, 2022
@dkocher dkocher marked this pull request as draft June 2, 2022 12:07
@dkocher dkocher added box Box Protocol Implementation dracoon DRACOON Protocol Implementation nextcloud labels Jun 2, 2022
@AliveDevil
Copy link
Contributor

Forbidden for Nextcloud.
image

@dkocher
Copy link
Contributor Author

dkocher commented Jun 3, 2022

Forbidden for Nextcloud.

I cannot reproduce the failure here.

POST /ocs/v2.php/apps/files_sharing/api/v1/shares?path=sandbox&shareType=3&publicUpload=true HTTP/1.1
OCS-APIRequest: true
Accept: application/xml
Content-Length: 0
Host: cloud.iterate.ch
Connection: Keep-Alive
User-Agent: Cyberduck/null.null (Mac OS X/12.4) (aarch64)
Cookie: __Host-nc_sameSiteCookielax=true; __Host-nc_sameSiteCookiestrict=true; oc7vsmzhpklo=7hqpkfo1vi52pront5v876o5is; oc_sessionPassphrase=H0jhNhmjXh9k5rf0SYLfzyRo6cKa8Gz4tDYp4%2F7S34qC1FO7th%2BPnomCN6fCf07IrOnda54XC7Or05ctJr7zeNIN7LY8aRJZxkp%2FvA4bRSfDjcTFec7AH6byEzMQ6I%2F9
Accept-Encoding: gzip,deflate
Authorization: Basic ****=

HTTP/1.1 200 OK
Server: nginx/1.20.0
…

@dkocher dkocher marked this pull request as ready for review June 3, 2022 12:48
@dkocher dkocher enabled auto-merge June 3, 2022 12:48
@dkocher
Copy link
Contributor Author

dkocher commented Jun 7, 2022

Forbidden for Nextcloud.

Added missing error handling in 8905e80.

@dkocher dkocher requested a review from AliveDevil June 7, 2022 18:13
@dkocher dkocher mentioned this pull request Jun 8, 2022
Closed
3 tasks
@dkocher dkocher merged commit 6f94bf9 into master Jun 8, 2022
@dkocher dkocher deleted the feature/GH-13426 branch June 8, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliveDevil AliveDevil Awaiting requested review from AliveDevil

Assignees
No one assigned
Labels
box Box Protocol Implementation dracoon DRACOON Protocol Implementation nextcloud
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

Add menu item to request files for protocols that support upload share links
2 participants
@dkocher @AliveDevil