Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15250. #15251

Merged
merged 8 commits into from
Oct 25, 2023
Merged

Fix #15250. #15251

merged 8 commits into from
Oct 25, 2023

Commits on Oct 23, 2023

  1. Do not access factory while instantiating implementation.

    @dkocher
    dkocher committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ca30c5a View commit details
    Browse the repository at this point in the history

  2. Remove instance variable requiring access to Local implementation w… 

    …hile loading preferences.
    @dkocher
    dkocher committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b8283ba View commit details
    Browse the repository at this point in the history

  3. Access defaults only after calling super.

    @dkocher
    dkocher committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    8c0ce95 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Delete unused property.

    @dkocher
    dkocher committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d3dc81a View commit details
    Browse the repository at this point in the history

  2. Logging for no-op usage.

    @dkocher
    dkocher committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    bcd8e85 View commit details
    Browse the repository at this point in the history

  3. Logging.

    @dkocher
    dkocher committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b745f34 View commit details
    Browse the repository at this point in the history

  4. Logging.

    @dkocher
    dkocher committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f13b113 View commit details
    Browse the repository at this point in the history

  5. Make sure no default implementation is registered.

    @dkocher
    dkocher committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    db85bd7 View commit details
    Browse the repository at this point in the history