Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to load public key when available #15254

Merged
merged 7 commits into from
May 15, 2024
Merged

Attempt to load public key when available #15254

merged 7 commits into from
May 15, 2024

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Oct 23, 2023

No description provided.

@dkocher dkocher added this to the 8.7.1 milestone Oct 23, 2023
@dkocher dkocher requested a review from a team as a code owner October 23, 2023 19:54
This was linked to issues Oct 23, 2023
Support OpenSSH with certificate user authentication #15183
Closed
Failure reading private key outside of ~/.ssh directory when running sandboxed #15252
Closed
@dkocher
Copy link
Contributor Author

dkocher commented Oct 23, 2023

Depends on hierynomus/sshj#908.

@dkocher dkocher marked this pull request as draft October 23, 2023 19:55
@dkocher dkocher mentioned this pull request Oct 25, 2023
Closed
@dkocher dkocher modified the milestones: 8.7.1, 8.7.2 Nov 3, 2023
@dkocher dkocher modified the milestones: 8.7.2, 8.7.3 Jan 10, 2024
@dkocher dkocher modified the milestones: 8.8.0, 8.8.1, 8.8.2 Mar 8, 2024
@dkocher dkocher modified the milestones: 8.8.2, 8.8.3 Apr 8, 2024
@dkocher dkocher marked this pull request as ready for review April 29, 2024 15:40
AliveDevil
AliveDevil requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@AliveDevil AliveDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login doesn't work - immediately fails.

sshd.log
cyberduck.log

@AliveDevil
Copy link
Contributor 

java.lang.NoSuchMethodError: 'void net.schmizz.sshj.userauth.keyprovider.FileKeyProvider.init(java.io.Reader, java.io.Reader, net.schmizz.sshj.userauth.password.PasswordFinder)'

@AliveDevil
Copy link
Contributor

Conflict in Dependencies:

[INFO] +- ch.iterate.ssh:sshj:jar:0.39.0:compile
[INFO] +- ch.iterate.ssh:jsch.agentproxy.sshj:jar:0.0.10:compile
[INFO] |  +- com.hierynomus:sshj:jar:0.38.0:compile

@dkocher dkocher requested a review from AliveDevil May 14, 2024 11:48
AliveDevil
AliveDevil requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@AliveDevil AliveDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step debugging revealed:
https://github.com/hierynomus/sshj/pull/908/files#r1600044608

@dkocher dkocher requested a review from AliveDevil May 14, 2024 19:56
@dkocher dkocher merged commit 1a0604a into master May 15, 2024
6 checks passed
@dkocher dkocher deleted the bugfix/GH-15252 branch May 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliveDevil AliveDevil AliveDevil approved these changes

@ylangisc ylangisc Awaiting requested review from ylangisc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.9.0
2 participants
@dkocher @AliveDevil