Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #5

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Fix dependencies #5

merged 2 commits into from
Jan 24, 2020

Conversation

shcheklein
Copy link
Member

@shcheklein shcheklein commented Jan 24, 2020

First step to fix iterative/dvc#3215 . More context is here - https://stackoverflow.com/a/59850170/298182

Step needed to fix gdrive dependencies in the DVC core repo, specifically these lines https://github.com/iterative/dvc/blob/master/setup.py#L87-L89

@efiop was you able to run tests/CI/stylers for this repo?

  • Will need to update conda deps and release new version to pip/conda.

@efiop
Copy link
Contributor

efiop commented Jan 24, 2020

@efiop was you able to run tests/CI/stylers for this repo?

Not yet 🙁 #3

@efiop efiop merged commit 330c4f9 into master Jan 24, 2020
@efiop efiop deleted the fix-a-few-issues branch January 24, 2020 07:42
@efiop
Copy link
Contributor

efiop commented Jan 24, 2020

Released 1.4.1, will adjust conda soon too.

@shcheklein
Copy link
Member Author

@efiop thanks! I'll create a PR to DVC core tomorrow.

@efiop
Copy link
Contributor

efiop commented Jan 24, 2020

@shcheklein No need, I've adjusted already. iterative/dvc@2f1224b

@shcheklein
Copy link
Member Author

thanks!

@efiop
Copy link
Contributor

efiop commented Jan 24, 2020

For the record: fixed conda conda-forge/pydrive2-feedstock#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some files are not uploaded to TeamDrive
2 participants