Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance telemetry data and exclude tensorboard tracebacks #1172

Merged
merged 24 commits into from
Oct 11, 2022
Merged

Enhance telemetry data and exclude tensorboard tracebacks #1172

merged 24 commits into from
Oct 11, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Sep 20, 2022 •
edited

  • Fix cml tensorboard logging whole Python Traceback to the telemetry backend
  • Allow to specify which options get logged to the telemetry backend

Hacks

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 20, 2022 03:57 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 20, 2022 04:00 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 20, 2022 04:07 Inactive
@casperdcl casperdcl mentioned this pull request Sep 20, 2022
Closed
dacbd
dacbd reviewed Sep 21, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
DavidGOrtega
DavidGOrtega previously requested changes Sep 21, 2022
View reviewed changes
Dockerfile Show resolved Hide resolved
bin/cml.js Outdated Show resolved Hide resolved
bin/cml.js Outdated Show resolved Hide resolved
bin/cml/tensorboard/connect.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@casperdcl casperdcl added technical-debt Refactoring, linting & tidying telemetry labels Sep 23, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 28, 2022 22:21 Inactive
@0x2b3bfa0 0x2b3bfa0 changed the title Enrich analytics with container information and options Enhance telemetry fields Sep 28, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 28, 2022 22:40 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 28, 2022 22:51 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 28, 2022 22:54 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 28, 2022 23:11 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 28, 2022 23:12 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 28, 2022 23:15 Inactive
@0x2b3bfa0 @tasdomas
Apply suggestions from code review
719dc9a 
Co-authored-by: Domas Monkus <domas@iterative.ai>
@0x2b3bfa0 0x2b3bfa0 dismissed stale reviews from tasdomas and dacbd via 719dc9a October 10, 2022 12:36
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 10, 2022 12:36 Inactive
tasdomas
tasdomas previously approved these changes Oct 10, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 15:08 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 17:23 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 17:34 Inactive
@0x2b3bfa0 0x2b3bfa0 requested review from DavidGOrtega and removed request for DavidGOrtega October 11, 2022 17:34
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 17:43 Inactive
@dacbd dacbd dismissed DavidGOrtega’s stale review October 11, 2022 21:38

Stale / resolved after meeting/verbal + review commits have been pushed

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 21:39 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 22:04 Inactive
0x2b3bfa0
0x2b3bfa0 commented Oct 11, 2022
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/images.yml Outdated Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 11, 2022 22:25 Inactive
@dacbd dacbd self-requested a review October 11, 2022 22:31
@0x2b3bfa0 0x2b3bfa0 merged commit 188cde1 into master Oct 11, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the enrich-analytics branch October 11, 2022 22:36
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jan 12, 2023
Open
7 tasks
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd approved these changes

@tasdomas tasdomas tasdomas left review comments

@DavidGOrtega DavidGOrtega Awaiting requested review from DavidGOrtega

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
technical-debt Refactoring, linting & tidying telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@0x2b3bfa0 @tasdomas @DavidGOrtega @dacbd @casperdcl