Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude internal projects & tests from analytics #1199

Merged
merged 5 commits into from
Oct 1, 2022
Merged

Exclude internal projects & tests from analytics #1199

merged 5 commits into from
Oct 1, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Sep 30, 2022 •
edited

I chose this approach versus setting ITERATIVE_DO_NOT_TRACK on all the workflows because we have dozens of them split over a lot of repositories.

Local development may still require additional precautions like setting the ITERATIVE_DO_NOT_TRACK environment variable locally.

Thanks, @omesser for noticing! 馃檹

@0x2b3bfa0 0x2b3bfa0 added the testing Unit tests & debugging label Sep 30, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from a team September 30, 2022 17:18
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 30, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 30, 2022 17:18 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 30, 2022 17:21 Inactive
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Sep 30, 2022
Merged
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 30, 2022 17:34 Inactive
dacbd
dacbd previously approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 馃憥 arguably we can ignore our group_id

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 1, 2022 00:39 Inactive
@0x2b3bfa0
Copy link
Member Author

dcd019d

Unlike usually, didn't feel like arguing today 馃槈

@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd October 1, 2022 00:41
@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) October 1, 2022 00:47
dacbd
dacbd approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0x2b3bfa0 0x2b3bfa0 merged commit f34a089 into master Oct 1, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the exclude-iterative-analytics branch October 1, 2022 00:53
@hohner2008 hohner2008 mentioned this pull request Feb 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
testing Unit tests & debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x2b3bfa0 @dacbd