dvc-cml container working with Gitlab and Github #12

DavidGOrtega · 2020-03-19T18:37:58Z

No description provided.

shcheklein · 2020-03-19T23:06:34Z

.github/workflows/deploy.yaml

+      - name: Publish to dockerhub
+        uses: elgohr/Publish-Docker-Github-Action@master
+        with:
+          name: davidgortega/dvc-cml


should we use iterative? where does this name go?

Good catch! This is actually an error, in the original branch I had it right but I had to redo it and I overlooked it.

shcheklein · 2020-03-19T23:08:45Z

README.md

-[your own runners](https://help.github.com/en/actions/hosting-your-own-runners)
-with special capabilities like GPUs.
+tool for ML experimentation. This repo offers the possibility of using DVC to
+establish your ML pipeline to be run by Github Actions runners or Gitlab


Github Action runners

The Github product is named Github Action, maybe has to be double quoted?

It was about typo Actions - Action .. in english you don't put two plurals one after another

shcheklein · 2020-03-19T23:09:56Z

README.md

+or [your own Gitlab runners](https://docs.gitlab.com/runner/) with special
+capabilities like GPUs...
+
+Major beneficts of using DVC-CML in your ML projects includes:


not clear so far what CML stands for to be honest

Continuous Machine Learning, I have not chosen the name but I really like it

shcheklein · 2020-03-19T23:11:48Z

README.md


 - Reproducibility: DVC is always in charge of maintain your experiment tracking
  all the dependencies, so you don't have to. Additionally your experiment is
-  always running under the same software constrains so you dont have to worry
-  about replicating the same enviroment again.
+  always running under the same constrains so you dont have to worry about


don't

do you run some editor with spell checking, by chance? )

I hope this is not going to be the real README! This is going to be redone by someone else as far I understand.

shcheklein · 2020-03-19T23:12:43Z

README.md

- Releases: DVC-action tags every experiment that runs with repro. Aside of that
-  DVC-action is just a job inside your workflow that could generate your model
-  releases or deployment according to your bussiness requirements.
+  experiments run through the DVC Report offeered as checks in Github or


same here ... please use some tools to fix simple language typos, stylistic mistakes, etc

shcheklein · 2020-03-19T23:13:42Z

README.md

+  experiments run through the DVC Report offeered as checks in Github or
+  Releases in Gitlab.
+- Releases: DVC-action tags every experiment that runs with repro generating the
+  report. Aside of that DVC-cml is just a step in your


DVC-cml or DVC-CML - use one style

shcheklein · 2020-03-19T23:15:58Z

README.md

+or [your own Gitlab runners](https://docs.gitlab.com/runner/) with special
+capabilities like GPUs...
+
+Major beneficts of using DVC-CML in your ML projects includes:


we mention benefits, and non of them about simple things that are essential to CI (running tests/training independently to make sure that build is "green") and we don't mention another big one - running infra for you to train something

Not sure about the last benefit, actually, I would expect ML users to be running their own runners using gpu, locally or cloud like AWS or Azure or any other gpu vendor.
IMHO the benefits of CI ML are Releases and Reproducibility and having everything containerised helps with that a lot since the environments are going to be consistent.

I mean, it still manages the workflow for you. As a data scientist I don't care if there is AWS machine or something - I just push and wait. I don't provision, dockerize, SSH, copy data, etc ... It's one of the major benefits of this whole thing unless I'm missing something cc @dmpetrov

Ok, I see. Yep, thats a benefit. Actually shared by teaming and reproducibility.
Its very easy to have a model and results just only branching and pushing new changes, without having to setup the enviroment.
And its reproducible since all are working with the same software/hardware constrains...

shcheklein · 2020-03-19T23:19:21Z

README.md

+
+Example of a simple DVC-cml workflow in Gitlab:
+
+> :eyes: Some needed variables like remote credentials and GITLAB_TOKEN are


needed -> required
variables -> environment variables
are setted -> are set (or even come up with a better term)
as CI/CD ... -> as Gitlab Runners ... in Gitlab settings ... or what is the right term here?

CI/CD enviroment variables is the way to go in Gitlab

shcheklein · 2020-03-19T23:19:30Z

README.md

+
+dvc:
+  stage: dvc_action_run
+  image: davidgortega/dvc-cml:dev


image name?

dvcorg/dvc-cml:latest

shcheklein · 2020-03-19T23:20:21Z

README.md

+</details>
+
+This workflow will run everytime that you push code or do a Pull/Merge Request.
+When triggered DVC-cml will setup the runner and DVC will run the pipelines
 specified by repro_targets. Two scenarios may happen:


repro_targets -> repro_targets

shcheklein · 2020-03-19T23:20:52Z

README.md

+| metrics_diff_targets | string | no       |               | Comma delimited array of metrics files. If not specified will use all the metric files         |
+| rev                  | string | no       | origin/master | Revision to be compared with current experiment. I.E. HEAD~1.                                  |
+
+> :warning: In Gitlab is needed that you generate the GITLAB_TOKEN that is


it is required

shcheklein · 2020-03-19T23:21:01Z

README.md

+
+> :warning: In Gitlab is needed that you generate the GITLAB_TOKEN that is
+> analogous to GITHUB_TOKEN. See
+> [Tensorflow Mnist in Gitlab](#tensorflow-mnist-in-gitlab) example For a


shcheklein · 2020-03-19T23:21:54Z

README.md

- actions/setup-python
-
-Example of a simple DVC-action workflow:
+> :eyes: Note the use of the container


explain why do I need to note this

To not forget it in the job definition. It might be a pitfall. People adding DVC-CML inside an existing job that and the don't add the container section

so, put that explanation in the note itself?

shcheklein · 2020-03-19T23:23:11Z

action.yml

@@ -1,29 +1,6 @@
 name: 'DVC-action'


is name, description different now?

Good catch! Its not actually doing anything and its only useful if we publish the repo as a Github Action

shcheklein · 2020-03-19T23:28:31Z

docker/Dockerfile

@@ -0,0 +1,27 @@
+FROM ubuntu:18.04
+
+LABEL Iterative Inc


minor: Iterative, Inc

shcheklein · 2020-03-19T23:33:32Z

src/gitlab.js

+  CI_PROJECT_URL,
+  CI_COMMIT_REF_NAME,
+  CI_COMMIT_SHA,
+  // CI_COMMIT_BEFORE_SHA,


if we don't need it - remove it

dmpetrov

👍 some comments are inline

.github/workflows/deploy.yaml

dmpetrov · 2020-03-19T23:39:25Z

.github/workflows/deploy.yaml

+      - name: Publish to dockerhub
+        uses: elgohr/Publish-Docker-Github-Action@master
+        with:
+          name: davidgortega/dvc-cml


should we use iterative/dvc-cml?

dvcorg/dvc-cml its the dockerhub 🙂

shcheklein · 2020-03-20T22:46:42Z

README.md

+or [your own Gitlab runners](https://docs.gitlab.com/runner/) with special
+capabilities like GPUs...
+
+Major benefits of using DVC-CML in your ML projects includes:


still don't understand this list of benefits ... can you summarize them w/o this official language - like A,B,C - the way you understand them?

Initial commit

9716faa

DavidGOrtega requested a review from dmpetrov March 19, 2020 18:38

shcheklein reviewed Mar 19, 2020

View reviewed changes

docker/Dockerfile Outdated

@@ -0,0 +1,27 @@

FROM ubuntu:18.04

LABEL Iterative Inc

Copy link

Member

shcheklein Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Iterative, Inc

shcheklein reviewed Mar 19, 2020

View reviewed changes

dmpetrov requested changes Mar 19, 2020

View reviewed changes

DavidGOrtega added 3 commits March 20, 2020 08:48

PR Fix typos

acd0d26

Fix docker repo and action name

8ae693e

Remove CI_COMMIT_BEFORE_SHA

922c039

dmpetrov approved these changes Mar 20, 2020

View reviewed changes

dmpetrov merged commit 37d8e9a into master Mar 20, 2020

dmpetrov deleted the dvc-cml-container branch March 20, 2020 19:15

shcheklein reviewed Mar 20, 2020

View reviewed changes

0x2b3bfa0 mentioned this pull request Jul 29, 2023

[Snyk] Upgrade @npcz/magic from 1.3.12 to 1.3.14 #1412

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dvc-cml container working with Gitlab and Github #12

dvc-cml container working with Gitlab and Github #12

DavidGOrtega commented Mar 19, 2020

shcheklein Mar 19, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 19, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 20, 2020

shcheklein Mar 19, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 19, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 19, 2020

shcheklein Mar 19, 2020

shcheklein Mar 19, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 20, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 19, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 19, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 19, 2020

shcheklein Mar 19, 2020

shcheklein Mar 19, 2020

shcheklein Mar 19, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 20, 2020

shcheklein Mar 19, 2020

DavidGOrtega Mar 20, 2020

shcheklein Mar 19, 2020

shcheklein Mar 19, 2020

dmpetrov left a comment

dmpetrov Mar 19, 2020

DavidGOrtega Mar 20, 2020 •

edited

shcheklein Mar 20, 2020

DavidGOrtega Mar 20, 2020


		Example of a simple DVC-cml workflow in Gitlab:

		> :eyes: Some needed variables like remote credentials and GITLAB_TOKEN are

dvc-cml container working with Gitlab and Github #12

dvc-cml container working with Gitlab and Github #12

Conversation

DavidGOrtega commented Mar 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmpetrov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DavidGOrtega Mar 20, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DavidGOrtega Mar 20, 2020 •

edited