Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cml comment create --publish by default #1208

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Oct 6, 2022

Behavior only changes for local Markdown links

@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request cml-comment Subcommand ui/ux User interface/experience labels Oct 6, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from a team October 6, 2022 16:17
@0x2b3bfa0 0x2b3bfa0 self-assigned this Oct 6, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 6, 2022 16:17 Inactive
tasdomas
tasdomas previously approved these changes Oct 6, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal October 7, 2022 03:52 Inactive
@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) October 7, 2022 16:01
@0x2b3bfa0 0x2b3bfa0 requested review from tasdomas and a team October 7, 2022 16:01
@dacbd
Copy link
Contributor

dacbd commented Oct 7, 2022

do we only publish if the file isn't in git, ie you can reference local files that are in your git repo in markdown for links too and they will be rendered(without using --publish) right?

@0x2b3bfa0
Copy link
Member Author

After this change, any local file referenced from the Markdown document will be automatically uploaded

@0x2b3bfa0 0x2b3bfa0 merged commit fe9a06f into master Oct 7, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the cml-comment-create-publish branch October 7, 2022 23:02
casperdcl added a commit to iterative/cml.dev that referenced this pull request Oct 17, 2022
0x2b3bfa0 pushed a commit to iterative/cml.dev that referenced this pull request Oct 18, 2022
* ref/comment: update --publish options

- follow-up to iterative/cml#1208
- follow-up to iterative/cml#1210

* more explicit, harder to miss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cml-comment Subcommand enhancement New feature or request ui/ux User interface/experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants