Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on non-existent local paths #1341

Merged
merged 7 commits into from Jun 3, 2023
Merged

Warn on non-existent local paths #1341

merged 7 commits into from Jun 3, 2023

Conversation

0x2b3bfa0
Copy link
Member

Used to debug discord#cml/1070944059931246652; we may consider merging this perhaps under the debug log level. 馃

@0x2b3bfa0 0x2b3bfa0 added cml-publish Subcommand ui/ux User interface/experience labels Feb 3, 2023
@0x2b3bfa0 0x2b3bfa0 requested a review from a team February 3, 2023 05:51
@0x2b3bfa0 0x2b3bfa0 self-assigned this Feb 3, 2023
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal February 3, 2023 05:51 — with GitHub Actions Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal February 3, 2023 05:53 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Test Comment

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal February 3, 2023 05:57 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Test Comment

@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review February 24, 2023 10:40
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal February 24, 2023 10:41 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Test Comment

dacbd
dacbd previously approved these changes Feb 24, 2023
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 3, 2023 01:27 — with GitHub Actions Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 3, 2023 01:28 — with GitHub Actions Inactive
@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) June 3, 2023 01:28
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 3, 2023 01:39 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@0x2b3bfa0 0x2b3bfa0 disabled auto-merge June 3, 2023 01:49
@0x2b3bfa0 0x2b3bfa0 merged commit 321d659 into master Jun 3, 2023
23 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the warn-publish-enoent branch June 3, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd left review comments

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
cml-publish Subcommand ui/ux User interface/experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x2b3bfa0 @dacbd