Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert GitLab Runner version pin #1343

Merged
merged 6 commits into from Jun 3, 2023
Merged

Conversation

0x2b3bfa0
Copy link
Member

Reverts #1333 and closes #1335; to be merged as soon as !3881 is released.

@0x2b3bfa0 0x2b3bfa0 added technical-debt Refactoring, linting & tidying blocked Dependent on something else ci-gitlab labels Feb 7, 2023
@0x2b3bfa0 0x2b3bfa0 requested a review from a team February 7, 2023 03:33
@0x2b3bfa0 0x2b3bfa0 self-assigned this Feb 7, 2023
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal February 7, 2023 03:33 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Test Comment

@dacbd
Copy link
Contributor

dacbd commented Feb 7, 2023

@0x2b3bfa0 convert to draft while it's blocked?

@0x2b3bfa0 0x2b3bfa0 marked this pull request as draft February 7, 2023 17:51
@tasdomas
Copy link
Contributor

15.8.2 is already out with the fix merged, should we land this?

@tasdomas tasdomas temporarily deployed to internal February 14, 2023 08:52 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Test Comment

@github-actions
Copy link
Contributor

Test Comment

@0x2b3bfa0
Copy link
Member Author

@tasdomas, it looks like it hasn't been released yet (?) 🤔

$ curl --location https://gitlab-runner-downloads.s3.amazonaws.com/latest/binaries/gitlab-runner-linux-amd64 --output /bin/gitlab-runner
...
$ gitlab-runner --version
Version:      15.8.2
Git revision: 4d1ca121
Git branch:   15-8-stable
GO version:   go1.18.9
Built:        2023-02-09T17:23:17+0000
OS/Arch:      linux/amd64
$ gitlab-runner run-single --executor=docker --url=https://gitlab.com --token=$GITLAB_RUNNER_REGISTRATION_TOKEN
...
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
...

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Feb 14, 2023

They haven't backported the patch to the 15-8-stable branch yet.

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal February 15, 2023 08:27 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Test Comment

@github-actions
Copy link
Contributor

Test Comment

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal February 24, 2023 10:25 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Test Comment

@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review February 24, 2023 10:37
@0x2b3bfa0 0x2b3bfa0 removed the blocked Dependent on something else label Feb 24, 2023
@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Feb 24, 2023

@iterative/cml, ready to merge after GitLab backported the fix to 15.8 stable.

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal February 24, 2023 10:39 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Test Comment

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal February 24, 2023 23:25 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Test Comment

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 3, 2023 01:17 — with GitHub Actions Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 3, 2023 01:17 — with GitHub Actions Inactive
@0x2b3bfa0 0x2b3bfa0 merged commit 3ab3125 into master Jun 3, 2023
7 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the revert-gitlab-runner-pin branch June 3, 2023 01:17
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-gitlab technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert GitLab Runner version pin
3 participants