Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No git sha dependencies #517

Merged
merged 1 commit into from
May 18, 2021
Merged

No git sha dependencies #517

merged 1 commit into from
May 18, 2021

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented May 15, 2021

Send comment and check need to get the sha from git despite that it has been provided.
Additionally cml-send-check and cml-send-comment have been aligned with the use of commit-sha

closes #478
closes #274

@DavidGOrtega DavidGOrtega self-assigned this May 15, 2021
@DavidGOrtega DavidGOrtega changed the base branch from master to release/v0.4.0 May 18, 2021 23:40
@DavidGOrtega DavidGOrtega merged commit dd0752f into release/v0.4.0 May 18, 2021
@DavidGOrtega DavidGOrtega deleted the no-sha-dep branch May 18, 2021 23:40
DavidGOrtega added a commit that referenced this pull request May 19, 2021
* No await runner (#523)

* cml-publish mime and repo (#519)

* cml-publish mime and repo

* cleanup

* image/svg+xml

* buffer

* resolve

* text buffer outputs plain

* native bolean

* snapshot

* Fix pipe reading logic on Windows (#516)

The fs.readSync function throws EOF instead of returning 0 like in other systems.
See nodejs/node#35997 for more information.

* minor doc fixes (#534)

* cml-pr command (#510)

* test-cml-pr

* packages

* pre-release

* log isci

* log isci

* user_name

* log gitlab url

* log gitlab url

* short 8

* len paths

* no undef

* git

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* sha2

* sha2

* log filepath

* log filepath

* log filepath

* exists and  clean

* SHA vs SHA2

* pre-release

* pre-release 2

* pre-release 3

* pre-release 3

* pre-release 3

* pre-release 3

* pre-release 3

* pre-release 3

* git back

* git back

* git back

* release

* REPO_TOKEN

* html_url

* cml pr defaults

* cml pr defaults

* test strict again

* CI

* vars

* shorter params

* snapshots and olivaw

* test david

* BB fix

* snapshots

* No git sha dependencies (#517)

* check head_sha

* 0.4.0

Co-authored-by: Helio Machado <0x2b3bfa0+git@googlemail.com>
Co-authored-by: Casper da Costa-Luis <work@cdcl.ml>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cml-send-comment fatal: not a git repository [cml-send-github-check] commit-sha
3 participants