Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replace on possibly undefined identifier #549

Merged
merged 1 commit into from
May 20, 2021
Merged

Fix replace on possibly undefined identifier #549

merged 1 commit into from
May 20, 2021

Conversation

0x2b3bfa0
Copy link
Member

Follow-up of #540, fixes #548

@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working cml-runner Subcommand labels May 20, 2021
@0x2b3bfa0 0x2b3bfa0 self-assigned this May 20, 2021
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to test-internal May 20, 2021 13:15 Inactive
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request May 20, 2021
Closed
casperdcl
casperdcl approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can merge directly into master as a hotfix

@0x2b3bfa0 0x2b3bfa0 merged commit c61fe70 into master May 20, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the fix-undefined-replace branch May 20, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

@DavidGOrtega DavidGOrtega Awaiting requested review from DavidGOrtega

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
bug Something isn't working cml-runner Subcommand
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with cml version 0.4.1
2 participants
@0x2b3bfa0 @casperdcl