cml-pr name branch

[DavidGOrtega]

GH gives branch names with all the ref /refs/heads/branch using branch name like this seems possible through their api but is breaking later on their UI

• Extracts the last part of the branch name

closes #551

[0x2b3bfa0]

TypeError: Cannot read property 'split' of undefined
    at branch_name (/usr/local/lib/node_modules/@dvcorg/cml/src/drivers/github.js:22:24)
    at Github.get branch [as branch] (/usr/local/lib/node_modules/@dvcorg/cml/src/drivers/github.js:298:12)
    at CML.branch (/usr/local/lib/node_modules/@dvcorg/cml/src/cml.js:88:13)
    at CML.pr_create (/usr/local/lib/node_modules/@dvcorg/cml/src/cml.js:267:31)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async run (/usr/local/lib/node_modules/@dvcorg/cml/bin/cml-pr.js:15:10)

Running locally in the absence of the GITHUB_REF environment variable. Should we cover this edge case?

[0x2b3bfa0]

Base branches with slashes in their names, like experiment/break-everything won't work on GitHub and, even if they did, would produce inconsistent results with other drivers. Admittedly, I did it on purpose. 😈

GITHUB_REF=experiment/break-everything cml-pr ···

{
  status: 422,
  headers: {···},
  request: {
    method: 'POST',
    url: 'https://api.github.com/repos/···/···/pulls',
    headers: {···},
    body: '{"head":"break-everything-cml-pr-···","base":"break-everything","title":"CML PR for break-everything 1a6ba96f","body":"\\nAutomated commits for https://github.com/···/···/commit/··· created by CML.\\n  "}',
    request: {···}
  },
  errors: [ { resource: 'PullRequest', field: 'base', code: 'invalid' } ],
  documentation_url: 'https://docs.github.com/rest/reference/pulls#create-a-pull-request'
}

[0x2b3bfa0]

Looks good to me! Nevertheless, the original error still is a mystery.

[casperdcl]

Base branches with slashes in their names, like experiment/break-everything won't work on GitHub

They should? Sounds like a bug

[DavidGOrtega]

@casperdcl @0x2b3bfa0 only happens apparently with refs/heads/

[0x2b3bfa0]

They should? Sounds like a bug

They should. Period. 😉

[0x2b3bfa0]

only happens apparently with refs/heads

Apparently, because I can't reproduce it with a minimal example.