Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat ops safety #558

Merged
merged 1 commit into from
May 27, 2021
Merged

chat ops safety #558

merged 1 commit into from
May 27, 2021

Conversation

casperdcl
Copy link
Contributor

  • contains => startsWith
  • admin/write permission
  • prefix # (e.g. /cmd\necho foo => #/cmd\necho foo)

@casperdcl casperdcl self-assigned this May 24, 2021
@casperdcl casperdcl temporarily deployed to test-internal May 24, 2021 15:37 Inactive
@casperdcl casperdcl added security Sensitive flaws technical-debt Refactoring, linting & tidying testing Unit tests & debugging labels May 24, 2021
DavidGOrtega
DavidGOrtega approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from lintCamel to devel May 27, 2021 15:28
@casperdcl casperdcl marked this pull request as ready for review May 27, 2021 16:02
@casperdcl casperdcl temporarily deployed to test-internal May 27, 2021 16:05 Inactive
@casperdcl casperdcl merged commit 685decb into devel May 27, 2021
@casperdcl casperdcl deleted the chatops branch May 27, 2021 16:06
@casperdcl casperdcl mentioned this pull request May 27, 2021
Merged
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGOrtega DavidGOrtega DavidGOrtega approved these changes

@0x2b3bfa0 0x2b3bfa0 Awaiting requested review from 0x2b3bfa0

Assignees

@casperdcl casperdcl

Labels
security Sensitive flaws technical-debt Refactoring, linting & tidying testing Unit tests & debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@casperdcl @DavidGOrtega