-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cml-send-comment --update
#581
Conversation
Given https://github.com/iterative/cml/wiki/Backend-Supported-Features we could still merge anyway |
|
445a05c
to
60ae09f
Compare
60ae09f
to
a3a5e1b
Compare
42ec6a7
to
0a971e4
Compare
0a971e4
to
20b785c
Compare
20b785c
to
6f7bbce
Compare
Hopefully I won't have to think about John Woods' quote for a long, long time. 😈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Bitbucket support won't be fully functional until users (cough) install the Pull Request Commit Links application. In the worst case scenario, commit comments will be created and pull request comments won't.
I wonder if we should unsupport Bitbucket. Sounds very flaky and confusing
What if we convert the disabled API warning into a fatal error and put it first? This way, users will need to enable the API before using |
Let's remove it then for Bitbucket. |
😱 I wouldn't remove BB functionality just because of a confusing one-click mechanism. Helpful error message (possibly throw/non-zero exit) plz. |
Ok but also has to be well documented, the last thing I want is we having to answer questions about why is not working in BB |
@DavidGOrtega & @casperdcl, do you like this fix à la #563ème? |
I miss #538 with granular tests and ephemeral repositories. 🐲 Having to manually delete comments before running automated tests is... far from ideal. FAIL src/drivers/bitbucket_cloud.test.js
[Forbidden] By default, you can't create more than 1000 comments per pull request. Contact support to update this limit. |
FAIL src/drivers/bitbucket_cloud.test.js This is weird, we fixed this already. As far as I remmber |
Running
cml-send-comment
with the newly introduced--update
flag will update the last CML comment instead of creating a new one. Comment authorship is determined by checking an invisible watermark [sic] added by CML to every machine-made comment. Watermarks are just void images appended with Markdown at the end of comments.Supported platforms
1 Blocked by gitlab-org/gitlab#333000; there is no known workaround.
2 Requires user interaction for the first time, as per #581 (comment).