Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maintainer in Dockerfile #601

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Update maintainer in Dockerfile #601

merged 1 commit into from
Jun 22, 2021

Conversation

0x2b3bfa0
Copy link
Member

Before: dvcorg support@cml.dev
After: CML support@cml.dev

@0x2b3bfa0 0x2b3bfa0 requested a review from casperdcl June 18, 2021 10:06
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jun 18, 2021
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 18, 2021 10:06 Inactive
@0x2b3bfa0 0x2b3bfa0 added the technical-debt Refactoring, linting & tidying label Jun 18, 2021
@DavidGOrtega
Copy link
Contributor

Not sure about this change @0x2b3bfa0 take into account that dvcorg is the maintainer of CML and indeed our npm package is @dvcorg/cml

The one who can answer this question is @dmpetrov

@0x2b3bfa0
Copy link
Member Author

Maybe we should keep it as-is until this proposal get any traction. I opened this pull request mainly to get rid of the comment. 😄

casperdcl
casperdcl approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik regardless of any future package/account name changes, this email has and will always make most sense

@DavidGOrtega
Copy link
Contributor

afaik regardless of any future package/account name changes, this email has and will always make most sense

But the email remains the same? Is that a British humour finesse? 😃

@casperdcl
Copy link
Contributor

I mean this particular docker image is maintained by CML so support should be @cml.dev, even though the org user may be different.

@0x2b3bfa0 0x2b3bfa0 merged commit 1c6fb1f into master Jun 22, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the update-dockerfile-maintainer branch June 22, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x2b3bfa0 @DavidGOrtega @casperdcl