-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test weekly (not daily) #604
Conversation
reduces number of comments on the commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that the discussion
label has been added on purpose. 😉
If we merge this, it should probably be only as a temporary measure to reduce notifications until we improve acceptance tests to create and use ephemeral repositories. Merging this will delay DVC updates on containers for a whole week (worst case scenario).
Could have a webhook/trigger (get DVC releases to instantly trigger this workflow) |
That would be awesome, but may require some workarounds for iterative/setup-dvc#9 (comment) / iterative/dvc#5542. |
That's a common issue - easily solved with a |
The use of arbitrary delays to fix timing issues on an otherwise event-driven system is one of my pet peeves. Nevertheless, yes, it should work; builds take ~8 minutes... until they don't. |
The purpose of running [acceptance] tests on a daily basis is just to test if CML still works as expected in conjunction with all the external infrastructure that it uses. There wouldn't be any use in running bit-perfect, local, deterministic tests on the main branch every 24 hours, 🙉 but running end to end tests that involve three different external services might be useful. CML is a no-service that, paradoxically, needs status monitoring. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyhow, given the currrent status of testing, I don't care if we throttle them a bit. If you want this to be merged, I'll press the green button at your command. 💣 💥 🍄 😄
Late now is mine MUAHAHAHAHAHAHA |
reduces number of test comments on the commit