Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test weekly (not daily) #604

Merged
merged 1 commit into from
Jul 4, 2021
Merged

test weekly (not daily) #604

merged 1 commit into from
Jul 4, 2021

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Jun 21, 2021

reduces number of test comments on the commit

reduces number of comments on the commit
@casperdcl casperdcl temporarily deployed to internal June 21, 2021 09:49 Inactive
@casperdcl casperdcl added discussion Waiting for team decision testing Unit tests & debugging labels Jun 21, 2021
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the discussion label has been added on purpose. 😉

If we merge this, it should probably be only as a temporary measure to reduce notifications until we improve acceptance tests to create and use ephemeral repositories. Merging this will delay DVC updates on containers for a whole week (worst case scenario).

@casperdcl
Copy link
Contributor Author

Could have a webhook/trigger (get DVC releases to instantly trigger this workflow)

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Jun 21, 2021

That would be awesome, but may require some workarounds for iterative/setup-dvc#9 (comment) / iterative/dvc#5542.

@casperdcl
Copy link
Contributor Author

That's a common issue - easily solved with a sleep 600 if triggered by a DVC release event.

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Jun 22, 2021

The use of arbitrary delays to fix timing issues on an otherwise event-driven system is one of my pet peeves. Nevertheless, yes, it should work; builds take ~8 minutes... until they don't.

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Jun 23, 2021

The purpose of running [acceptance] tests on a daily basis is just to test if CML still works as expected in conjunction with all the external infrastructure that it uses. There wouldn't be any use in running bit-perfect, local, deterministic tests on the main branch every 24 hours, 🙉 but running end to end tests that involve three different external services might be useful.

CML is a no-service that, paradoxically, needs status monitoring. 😉

Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyhow, given the currrent status of testing, I don't care if we throttle them a bit. If you want this to be merged, I'll press the green button at your command. 💣 💥 🍄 😄

@DavidGOrtega
Copy link
Contributor

Anyhow, given the currrent status of testing, I don't care if we throttle them a bit. If you want this to be merged, I'll press the green button at your command. 💣 💥 🍄 😄

Late now is mine MUAHAHAHAHAHAHA

@DavidGOrtega DavidGOrtega merged commit 62c05fc into master Jul 4, 2021
@DavidGOrtega DavidGOrtega deleted the test-schedule branch July 4, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Waiting for team decision testing Unit tests & debugging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants