Skip Terraform version checks when not needed #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform should not be a dependency for invocations that don't include --cloud or --tf-resource
DavidGOrtega
suggested changes
Jun 28, 2021
|
@DavidGOrtega, is there any scenario where the termination code is executed without reaching first the startup code? |
|
Non cloud runner do not have tf-resource however when terminating is going to try to destroy |
|
🤦🏼 So true! |
|
@DavidGOrtega, please take a look at the latest changes. I haven't tested them yet, but it looks like that should do the trick. 🙊 |
DavidGOrtega
approved these changes
Jun 28, 2021
Additionally, refactor block to use true conditionals instead of && shortcut conditionals.
0x2b3bfa0
force-pushed
the
check-terraform-version-when-needed
branch
from
0572a3a
to
a0e0f57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform should not be a dependency for invocations that don't include
--cloudor--tf-resourceoptions. Should fix #612.