Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API friendly runners #657

Merged
merged 1 commit into from
Jul 13, 2021
Merged

API friendly runners #657

merged 1 commit into from
Jul 13, 2021

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented Jul 13, 2021 •
edited

  • runnerByname and runnersByLabels can reuse existing runners
  • adds 100 elements in every GH page
  • adds api throttling in GH with 5 retries waiting the specified time

closes #655

@DavidGOrtega DavidGOrtega temporarily deployed to internal July 13, 2021 14:30 Inactive
@0x2b3bfa0
Copy link
Member

Awesome!

@DavidGOrtega DavidGOrtega temporarily deployed to internal July 13, 2021 14:37 Inactive
@DavidGOrtega DavidGOrtega self-assigned this Jul 13, 2021
@DavidGOrtega DavidGOrtega marked this pull request as draft July 13, 2021 14:43
@DavidGOrtega DavidGOrtega marked this pull request as ready for review July 13, 2021 14:51
@DavidGOrtega DavidGOrtega merged commit b5c1afb into master Jul 13, 2021
@DavidGOrtega DavidGOrtega deleted the runners-api-friendly branch July 13, 2021 16:59
casperdcl
casperdcl reviewed Jul 13, 2021
View reviewed changes
bin/cml-runner.js
Comment on lines +327 to +328
const runner = await cml.runnerByName({ name, runners });
if (runner) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const runner = await cml.runnerByName({ name, runners });
if (runner) {
if (await cml.runnerByName({ name, runners })) {

casperdcl
casperdcl reviewed Jul 13, 2021
View reviewed changes
src/cml.js Show resolved Hide resolved
casperdcl
casperdcl reviewed Jul 13, 2021
View reviewed changes
src/cml.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl left review comments

Assignees

@DavidGOrtega DavidGOrtega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploying multiple runners fails with github rate limit after version 0.5.0
3 participants
@DavidGOrtega @0x2b3bfa0 @casperdcl