Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest global timeout and fixes #693

Merged
merged 4 commits into from
Aug 16, 2021
Merged

Jest global timeout and fixes #693

merged 4 commits into from
Aug 16, 2021

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented Aug 16, 2021 •
edited
Loading

Cleanups the mess of setTimeout.

@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 11:49 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 12:23 Inactive
@casperdcl casperdcl added the testing Unit tests & debugging label Aug 16, 2021
@casperdcl casperdcl self-requested a review August 16, 2021 14:18
@casperdcl
Copy link
Contributor

actually looks like tests are failing

@DavidGOrtega
Copy link
Contributor Author

DavidGOrtega commented Aug 16, 2021 •
edited
Loading

actually looks like tests are failing

@casperdcl yes, there are. There is an issue with jest, promises and setInterval. All the PRs are failing because of that.
Very tricky. Im fixing it

@DavidGOrtega DavidGOrtega marked this pull request as draft August 16, 2021 14:20
@0x2b3bfa0 0x2b3bfa0 linked an issue Aug 16, 2021 that may be closed by this pull request
Tests hang forever #694
Closed
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 14:56 Inactive
@DavidGOrtega DavidGOrtega changed the title Jest global timeout Jest global timeout and fixes Aug 16, 2021
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 15:00 Inactive
@DavidGOrtega DavidGOrtega marked this pull request as ready for review August 16, 2021 15:00
@DavidGOrtega DavidGOrtega mentioned this pull request Aug 16, 2021
Merged
@DavidGOrtega DavidGOrtega merged commit 899c6d2 into master Aug 16, 2021
@DavidGOrtega DavidGOrtega deleted the jest-global-timeout branch August 16, 2021 15:14
@DavidGOrtega DavidGOrtega temporarily deployed to internal August 16, 2021 15:38 Inactive
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Aug 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl Awaiting requested review from casperdcl

Assignees

@DavidGOrtega DavidGOrtega

Labels
testing Unit tests & debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests hang forever Jest execution time is getting higher
2 participants
@DavidGOrtega @casperdcl