Add missing backslash on container ENTRYPOINT #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging with GitLab tests in red for obvious reasons. |
|
The docker images are deployed both on release & on schedule to grab updates. cml/.github/workflows/test-deploy.yml Lines 155 to 157 in d1daa8d |
|
馃う馃徏 (my turn) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silly mistake that I missed when reviewing #716: if
ENTRYPOINTdoesn't contain a valid JSON array, it's going to be interpreted as a shell command, producing errors like the following:It's breaking all our GitLab tests, but it should not, as CML has not been released since July 28th. 馃 Has somebody manually deployed our container images lately?