Manage all the environment variables through yargs #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave environment variable management to yargs
This was
linked to
issues
Sep 23, 2021
* Remove multiplatform legacy command tests Closes #736 * Apply @casperdcl's suggestion Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org> Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
* ...force pushed to trigger tests again after #733
0x2b3bfa0
added a commit
that referenced
this pull request
Sep 24, 2021
* Convert yargs builder function calls to plain objects Leave environment variable management to yargs * Remove dead code * Manage all the environment variables through yargs (#739) * Fix comment blunder * replace null * tf template check * add null option * clean up * use undefined * rm redundant debug logging * update from draft example * clean up * Update tests Additionally, * Handle falsy values as empty strings * Simplify template code Co-authored-by: Helio Machado <0x2b3bfa0+git@googlemail.com>
DavidGOrtega
added a commit
that referenced
this pull request
Oct 15, 2021
* Convert yargs builder function calls to plain objects Leave environment variable management to yargs * Remove dead code * Manage all the environment variables through yargs (#739) * Fix comment blunder * replace null * tf template check * add null option * clean up * use undefined * rm redundant debug logging * update from draft example * clean up * Update tests Additionally, * Handle falsy values as empty strings * Simplify template code Co-authored-by: Helio Machado <0x2b3bfa0+git@googlemail.com> Co-authored-by: Daniel Barnes <dabarnes2b@gmail.com> Co-authored-by: davidgortega <g.ortega.david@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would close #738, depends on #712