index: load: ignore misc exceptions #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
- Coverage 61.45% 61.41% -0.04%
==========================================
Files 57 57
Lines 3803 3807 +4
Branches 671 672 +1
==========================================
+ Hits 2337 2338 +1
- Misses 1330 1332 +2
- Partials 136 137 +1
☔ View full report in Codecov by Sentry. |
shcheklein
reviewed
Jul 27, 2023
| @@ -540,6 +544,9 @@ def _load_from_storage(trie, entry, storage_info): | |||
| return | |||
| except (FileNotFoundError, ObjectFormatError): | |||
| pass | |||
| except Exception: # pylint: disable=W0703 | |||
| # NOTE: this might be some random fs exception, e.g. auth error | |||
| logger.exception("failed to load %s", entry.key) | |||
There was a problem hiding this comment.
will users see this? can it happen in a CLI case ...
overall looks a bit fragile
There was a problem hiding this comment.
For now just ignoring, later will likely add an onerror mechanism.
efiop
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.