Skip to content

Commit

Permalink
fs: http: do not timeout on sock_read
Browse files Browse the repository at this point in the history
We have been getting reports that the timeout on sock_read was raising
timeout error even for chunked uploads, and sometimes even uploading
zero-byte files.

See: https://github.com/iterative/dvc/issues/8065
and iterative/dvc#8100.

These kinds of logics don't belong here, and should be upstreamed (eg: RetryClient/ClientTimeout, etc).
We added timeout in iterative/dvc#7460 because of freezes in
iterative/dvc#7414.

I think we can rollback this for now given that there are lots of report of failures/issues with this line,
and if we get any new reports of hangs, we'll investigate it separately.
  • Loading branch information
skshetry authored and efiop committed Aug 5, 2022
1 parent 805a716 commit 89718eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/dvc_objects/fs/implementations/http.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ async def get_client(self, **kwargs):
total=None,
connect=self.REQUEST_TIMEOUT,
sock_connect=self.REQUEST_TIMEOUT,
sock_read=self.REQUEST_TIMEOUT,
sock_read=None,
)

return RetryClient(**kwargs)
Expand Down

0 comments on commit 89718eb

Please sign in to comment.