Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move confusion matrix text to tooltip #127

Merged
merged 1 commit into from
Apr 20, 2023
Merged

move confusion matrix text to tooltip #127

merged 1 commit into from
Apr 20, 2023

Conversation

dberenbaum
Copy link
Contributor

Related to https://iterativeai.slack.com/archives/C01SR9Q12LB/p1681991760838949?thread_ts=1681958116.002649&cid=C01SR9Q12LB

Before:
Screenshot 2023-04-20 at 8 04 36 AM

After:
Screenshot 2023-04-20 at 8 02 57 AM

Doesn't necessarily look better for this example, but generally I think it will work better to have the values in the tooltip for anything beyond binary classification.

@dberenbaum dberenbaum requested a review from daavoo April 20, 2023 12:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (33eae51) 94.49% compared to head (ddc98ef) 94.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files          19       19           
  Lines         726      726           
  Branches      113      113           
=======================================
  Hits          686      686           
  Misses         27       27           
  Partials       13       13           
Impacted Files Coverage Δ
src/dvc_render/vega_templates.py 93.87% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense to me.

BUT 😅 , every change like this makes me wonder if we could come up with a better UX to customize these things.
To avoid having to be opinionated and still not requiring users to write a full new Vega template

@dberenbaum
Copy link
Contributor Author

BUT 😅 , every change like this makes me wonder if we could come up with a better UX to customize these things.
To avoid having to be opinionated and still not requiring users to write a full new Vega template

Yup, this is the direction I was going with #109. Agree that it would be way more intuitive to customize from a UI like in VS Code rather than mess around with Vega or dvc.yaml.

In this case, however, it seemed not worth having an option to customize, and it's probably okay to be opinionated.

@dberenbaum dberenbaum merged commit 8aab523 into main Apr 20, 2023
@dberenbaum dberenbaum deleted the confusion_text branch April 20, 2023 13:28
@dberenbaum
Copy link
Contributor Author

Not sure if it's worth a release. I'd be fine waiting on other changes.

@shcheklein
Copy link
Member

Not sure if it's worth a release. I'd be fine waiting on other changes.

why not, let's release ... we should be publishing things as we go :)

@dberenbaum
Copy link
Contributor Author

dberenbaum commented Apr 20, 2023

@shcheklein Do you plan another PR about this like you mentioned in https://iterativeai.slack.com/archives/C01SR9Q12LB/p1682002565617949?

@shcheklein
Copy link
Member

@dberenbaum yes! I'll try to do it today. It might touch this repo. Kk, let's wait a bit :)

@dberenbaum
Copy link
Contributor Author

Okay, no rush. I'll set a reminder to release if I don't see anything in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants