-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move confusion matrix text to tooltip #127
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 19 19
Lines 726 726
Branches 113 113
=======================================
Hits 686 686
Misses 27 27
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change makes sense to me.
BUT 😅 , every change like this makes me wonder if we could come up with a better UX to customize these things.
To avoid having to be opinionated and still not requiring users to write a full new Vega template
Yup, this is the direction I was going with #109. Agree that it would be way more intuitive to customize from a UI like in VS Code rather than mess around with Vega or In this case, however, it seemed not worth having an option to customize, and it's probably okay to be opinionated. |
Not sure if it's worth a release. I'd be fine waiting on other changes. |
why not, let's release ... we should be publishing things as we go :) |
@shcheklein Do you plan another PR about this like you mentioned in https://iterativeai.slack.com/archives/C01SR9Q12LB/p1682002565617949? |
@dberenbaum yes! I'll try to do it today. It might touch this repo. Kk, let's wait a bit :) |
Okay, no rush. I'll set a reminder to release if I don't see anything in the next few days. |
Related to https://iterativeai.slack.com/archives/C01SR9Q12LB/p1681991760838949?thread_ts=1681958116.002649&cid=C01SR9Q12LB
Before:
![Screenshot 2023-04-20 at 8 04 36 AM](https://user-images.githubusercontent.com/2308172/233360946-75b29990-770a-4151-aa26-06ba2cf0d80c.png)
After:
![Screenshot 2023-04-20 at 8 02 57 AM](https://user-images.githubusercontent.com/2308172/233360990-5b2e226c-7624-4a88-a4e0-d5ba1d488dc5.png)
Doesn't necessarily look better for this example, but generally I think it will work better to have the values in the tooltip for anything beyond binary classification.