Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vega: Fix custom templates when data is not the first dict in the t… #132

Merged
merged 1 commit into from
May 16, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 16, 2023

…emplate.

The has_anchor check was returning at the first dictionary encounter so even if the template had a valid data anchor, it would fail if it was not the first dictionary.

…emplate.

The `has_anchor` check was returning at the first dictionary encounter so even if the template had a valid `data` anchor, it would fail if it was not the first dictionary.
@daavoo daavoo self-assigned this May 16, 2023
@daavoo daavoo added A: vega Area: Vega plots bug Something isn't working labels May 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.85 🎉

Comparison is base (a4099d3) 95.52% compared to head (ef1a925) 96.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   95.52%   96.37%   +0.85%     
==========================================
  Files          19       19              
  Lines         759      772      +13     
  Branches      120      122       +2     
==========================================
+ Hits          725      744      +19     
+ Misses         19       16       -3     
+ Partials       15       12       -3     
Impacted Files Coverage Δ
src/dvc_render/vega_templates.py 95.94% <100.00%> (+2.06%) ⬆️
tests/test_vega.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo requested a review from dberenbaum May 16, 2023 11:05
@daavoo daavoo merged commit dc5fb16 into main May 16, 2023
13 checks passed
@daavoo daavoo deleted the fix-custom-templates-data branch May 16, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: vega Area: Vega plots bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants