-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown
support.
#69
Conversation
@@ -81,7 +81,6 @@ def embed(self) -> str: | |||
def render_html( | |||
renderers: List["Renderer"], | |||
output_file: "StrPath", | |||
metrics: Optional[Dict[str, Dict]] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover from #61
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 97.14% 95.65% -1.49%
==========================================
Files 16 19 +3
Lines 491 622 +131
Branches 77 90 +13
==========================================
+ Hits 477 595 +118
- Misses 8 22 +14
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should require users to install altair to support all vega plots in md?
I initially considered it but decided to go with matplotlib mainly because:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now wonder if this use case is not another point for dvc-render
to have some support for javascript. If there is some pythonic wrapper for js maybe we could leverage vega to produce images in non-linear template use cases. But I guess that would require some research to determine this idea's feasibility.
image: Add `generate_markdown`. vega: Add `generate_markdown`. "Translate" vega plot to `matplotlib` figure to save as `png`. Introduce `render_markdown`. Closes #62
DVC passes some values as `rich.Text` instead of string. As an oversight in #69 , the refactor to use `list_dict_to_dict_list` removed this string casting, breaking `dvc exp show --pcp`
DVC passes some values as `rich.Text` instead of string. As an oversight in #69 , the refactor to use `list_dict_to_dict_list` removed this string casting, breaking `dvc exp show --pcp`
DVC passes some values as `rich.Text` instead of string. As an oversight in #69 , the refactor to use `list_dict_to_dict_list` removed this string casting, breaking `dvc exp show --pcp`
DVC passes some values as `rich.Text` instead of string. As an oversight in #69 , the refactor to use `list_dict_to_dict_list` removed this string casting, breaking `dvc exp show --pcp`
DVC passes some values as `rich.Text` instead of string. As an oversight in #69 , the refactor to use `list_dict_to_dict_list` removed this string casting, breaking `dvc exp show --pcp`
Cutting quite a few corners to cover the minimum for iterative/dvclive#91
Proper refactor would make sense as follow-up because the whole package was focused on a single output format (HTML).
table: Add
generate_markdown
.image: Add
generate_markdown
.vega: Add
generate_markdown
."Translate" vega plot to
matplotlib
figure to save aspng
.Introduce
render_markdown
.Closes #62