Skip to content

Commit

Permalink
tests: move tests from dvc
Browse files Browse the repository at this point in the history
  • Loading branch information
efiop committed Aug 16, 2023
1 parent e6f0d74 commit 7d56bad
Showing 1 changed file with 138 additions and 0 deletions.
138 changes: 138 additions & 0 deletions dvc_s3/tests/test_s3.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,138 @@
import os

import pytest
from dvc_s3 import S3FileSystem

from dvc.fs import ConfigError

bucket_name = "bucket-name"
prefix = "some/prefix"
url = f"s3://{bucket_name}/{prefix}"
key_id = "key-id"
key_secret = "key-secret"
session_token = "session-token"


@pytest.fixture(autouse=True)
def grants():
return {
"grant_read": "id=read-permission-id,id=other-read-permission-id",
"grant_read_acp": "id=read-acp-permission-id",
"grant_write_acp": "id=write-acp-permission-id",
"grant_full_control": "id=full-control-permission-id",
}


def test_verify_ssl_default_param():
config = {"url": url}
fs = S3FileSystem(**config)

assert "client_kwargs" not in fs.fs_args

config = {
"url": url,
"endpointurl": "https://my.custom.s3:1234",
}
fs = S3FileSystem(**config)

assert "verify" not in fs.fs_args["client_kwargs"]


def test_s3_config_credentialpath(monkeypatch):
environment = {}
monkeypatch.setattr(os, "environ", environment)

config = {"url": url, "credentialpath": "somewhere"}
S3FileSystem(**config).fs_args
assert environment["AWS_SHARED_CREDENTIALS_FILE"] == "somewhere"
environment.clear()

config = {"url": url, "configpath": "somewhere"}
S3FileSystem(**config).fs_args
assert environment["AWS_CONFIG_FILE"] == "somewhere"
environment.clear()

config = {
"url": url,
"credentialpath": "somewhere",
"configpath": "elsewhere",
}
S3FileSystem(**config).fs_args
assert environment["AWS_SHARED_CREDENTIALS_FILE"] == "somewhere"
assert environment["AWS_CONFIG_FILE"] == "elsewhere"
environment.clear()


def test_ssl_verify_bool_param():
config = {"url": url, "ssl_verify": False}
fs = S3FileSystem(**config)

assert fs.fs_args["client_kwargs"]["verify"] == config["ssl_verify"]


def test_ssl_verify_path_param():
config = {"url": url, "ssl_verify": "/path/to/custom/cabundle.pem"}
fs = S3FileSystem(**config)

assert fs.fs_args["client_kwargs"]["verify"] == config["ssl_verify"]


def test_ssl_verify_none_param():
config = {"url": url, "ssl_verify": None}
fs = S3FileSystem(**config)

assert "client_kwargs" not in fs.fs_args

config = {
"url": url,
"endpointurl": "https://my.custom.s3:1234",
"ssl_verify": None,
}
fs = S3FileSystem(**config)

assert "verify" not in fs.fs_args["client_kwargs"]


def test_grants():
config = {
"url": url,
"grant_read": "id=read-permission-id,id=other-read-permission-id",
"grant_read_acp": "id=read-acp-permission-id",
"grant_write_acp": "id=write-acp-permission-id",
"grant_full_control": "id=full-control-permission-id",
}
fs = S3FileSystem(**config)

extra_args = fs.fs_args["s3_additional_kwargs"]
assert (
extra_args["GrantRead"] == "id=read-permission-id,id=other-read-permission-id"
)
assert extra_args["GrantReadACP"] == "id=read-acp-permission-id"
assert extra_args["GrantWriteACP"] == "id=write-acp-permission-id"
assert extra_args["GrantFullControl"] == "id=full-control-permission-id"


def test_grants_mutually_exclusive_acl_error(grants):
for grant_option, grant_value in grants.items():
config = {"url": url, "acl": "public-read", grant_option: grant_value}

fs = S3FileSystem(**config)
with pytest.raises(ConfigError):
fs.fs_args


def test_sse_kms_key_id():
fs = S3FileSystem(url=url, sse_kms_key_id="key")
assert fs.fs_args["s3_additional_kwargs"]["SSEKMSKeyId"] == "key"


def test_key_id_and_secret():
fs = S3FileSystem(
url=url,
access_key_id=key_id,
secret_access_key=key_secret,
session_token=session_token,
)
assert fs.fs_args["key"] == key_id
assert fs.fs_args["secret"] == key_secret
assert fs.fs_args["token"] == session_token

0 comments on commit 7d56bad

Please sign in to comment.