Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get started: wrong md5 of the data.xml #529

Closed
dniku opened this issue Aug 7, 2019 · 2 comments
Closed

get started: wrong md5 of the data.xml #529

dniku opened this issue Aug 7, 2019 · 2 comments
Labels
A: docs Area: user documentation (gatsby-theme-iterative) duplicate This issue or pull request already exists. type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@dniku
Copy link

dniku commented Aug 7, 2019

(dvc version and other environment details are probably irrelevant)

https://dvc.org/doc/get-started/add-files suggests that the MD5 hash of data.xml is a304afb96060aad90176268345e10355, but it is actually not:

$ md5sum data.xml
a86ca87250ed8e54a9e2e8d6d34c252e  data.xml

However, .dvc/cache still contains a3/04afb96060aad90176268345e10355. Perhaps a footnote explanation of the discrepancy would help improve the documentation?

@shcheklein shcheklein transferred this issue from iterative/dvc Aug 7, 2019
@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions labels Aug 7, 2019
@shcheklein shcheklein changed the title md5sum of https://dvc.org/s3/get-started/data.xml is a86ca87250ed8e54a9e2e8d6d34c252e get started: wrong md5 of the data.xml Aug 7, 2019
@shcheklein
Copy link
Member

Most likely:

Related: #68 .
Related: iterative/dvc#992

@dniku to give a bit more context. DVC is doing dos2unix normalization before running md5 on the file. This is why you see this discrepancy.

We were hesitant to document the way it's calculated now because we want to remove this normalization in the future, but it looks like it's better to put a section somewhere that describes it.

@dniku
Copy link
Author

dniku commented Aug 7, 2019

Thank you for a prompt comment. I suppose this issue should be closed, as it duplicates #68.

@dniku dniku closed this as completed Aug 7, 2019
@shcheklein shcheklein added the duplicate This issue or pull request already exists. label Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) duplicate This issue or pull request already exists. type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

2 participants