Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a user-guide section for "DVC Internals" #838

Closed
dashohoxha opened this issue Dec 4, 2019 · 5 comments
Closed

create a user-guide section for "DVC Internals" #838

dashohoxha opened this issue Dec 4, 2019 · 5 comments
Labels
A: docs Area: user documentation (gatsby-theme-iterative) status: research Writing concrete steps for the issue

Comments

@dashohoxha
Copy link
Contributor

This section will basically reorganize and contain some of the existing pages/sections:

@shcheklein
Copy link
Member

Unless I'm missing the meaning of "internals", only Structure of Cache Directory can be considered one. May be "How DVC Understands Data Changes".

@shcheklein shcheklein added status: research Writing concrete steps for the issue A: docs Area: user documentation (gatsby-theme-iterative) labels Dec 4, 2019
@dashohoxha
Copy link
Contributor Author

Unless I'm missing the meaning of "internals"

In my opinion "internals" are all the things that are related to implementation details, and could be changed one day (maybe to improve performance or something else) without changing the functionality of the interface (commands and their options).

So, I think that internal may also be considered the content of DVC-files (*.dvc), although we explain it starting from the Get Started. I would also regard the content of the directory .dvc as internal.

@shcheklein
Copy link
Member

shcheklein commented Dec 5, 2019

In my opinion "internals" are all the things that are related to implementation details, and could be changed one day (maybe to improve performance or something else) without changing the functionality of the interface (commands and their options).

🤝 that's absolutely correct! That's how I understand this as well.

So, I think that internal may also be considered the content of DVC-files (*.dvc), although we explain it starting from the Get Started.

yep, DVC-file is a public interface. It can be edited manually. We need to support backward compatibility, etc

I would also regard the content of the directory .dvc as internal.

Just some portion of it (like cache dir). config for example is a public interface again.

So, please adjust the description and let's see if we have enough material and what can we do with it.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Dec 11, 2019

Idk. Most of this is covered in https://dvc.org/doc/user-guide/dvc-files-and-directories and https://dvc.org/doc/user-guide/dvc-file-format. Maybe its best to have them separate to keep the guides short-medium sized

In my opinion "internals" are all the things that are related to implementation details...

I think our User Guide super section serves this purpose.

As I see no updates after Ivan's comment above, I vote to close this one for now. Feel free to re-open if there are more details. Thanks!

@jorgeorpinel
Copy link
Contributor

p.s. user-guide: new "Basic Concepts" doc(s) #550 may also help cover any gaps that motivated this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) status: research Writing concrete steps for the issue
Projects
None yet
Development

No branches or pull requests

3 participants