docs: rename plot -> plots

[efiop]

Per iterative/dvc#3802

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please chose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

[efiop]

Looks like I also need to rename images and .dvc/plot to .dvc/plots

[efiop]

Getting

#!/bin/bash -eo pipefail
yarn link-check-diff
yarn run v1.22.4
$ ./scripts/link-check-git-diff.sh
~/repo ~/repo
config/prismjs/dvc-commands.js:/dev/fd/63:OK
content/blog/2020-04-30-gsod-ideas-2020.md:/dev/fd/63:OK
content/blog/2020-05-04-dvc-3-years-and-1-0-release.md:/dev/fd/63:OK
content/docs/command-reference/plots/diff.md:/dev/fd/63:
 ERROR:404:https://dvc.org/doc/command-reference/plots
ERROR:1 failures
---
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Exited with code exit status 1

seems like it is not picking up that the plots already exists? https://dvc-landing-plot-plots-9bmmtfj.herokuapp.com/doc/command-reference/plots

[efiop]

Also:

./img/plot_show_field.svg                        
./img/plot_show_json.svg                         
./img/plot_show_json_field.svg                   
./img/plot_diff_confusion.svg                    
./img/plot_auc.svg                               
./img/plot_show_confusion.svg                    
./img/plot_diff.svg                              
./img/plot_diff_workspace.svg                    
./img/plot_show.svg                              
./uploads/images/2020-05-04/dvc-plot.svg         
./uploads/images/2020-05-04/dvc-plot-scatter.svg 
./uploads/images/2020-02-17/freq_plot.svg        

should I rename these or it doesn't matter or there are some bad consequences (i dunno, maybe caching will be confused?)?

[jorgeorpinel]

ERROR:404:https://dvc.org/doc/command-reference/plots

Yeah this is a known problem in the link checker I think, please ignore it for now. Cc @casperdcl

[jorgeorpinel]

should I rename these

Good catch about the image files. I would say let's rename them. I don't think it causes any caching issue but maybe @shcheklein knows better.

[jorgeorpinel]

Thanks! Please request my review again if/when the core repo PR is merged.

[shcheklein]

should I rename these

not problems with caching or something, just rename and change links. But to be honest it is 💅 ... plot or plots for images names I think is not important :)

[jorgeorpinel]

LGTM, please merge if/when the core repo PR is merged.