-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add video of sharing exps via vs code #4865
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
daff50c
add video of sharing exps via vs code
dberenbaum 661c5eb
Merge branch 'main' into vscode-product-updates
dberenbaum 48c8529
update url to auto-play youtube video muted
yathomasi c0eec9f
Merge branch 'main' into vscode-product-updates
dberenbaum File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Q] Did you rewatch this video to make sure it has the correct content? Should the link be to this one? Also... can we use a gif instead 😄 😬.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @mattseddon is right here and this brings up an interesting question on language. The video Matt is suggesting is talking about "sharing" experiments to Studio, while the more recent one is about sharing with a colleague. Maybe we need to define language around this to be more clear? Maybe "sharing" should be used for collaboration things and we should use another term for sharing to DVC Studio? Cast to Studio? Send to Studio? Sync with Studio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear I don't think we need to redo the video. I could easily adjust the thumbnail, title and description wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I thought this was a good video for here because it goes end to end from adding the token, to pushing experiments, to sharing a studio link.
Up to you. My take would be that besides saving you form having to do two versions of product updates, having you talk through it is more helpful and easier to follow.