Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #657: Reorganize tutorials into their own section. #666

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Conversation

dashohoxha
Copy link
Contributor

Fix #657

@shcheklein shcheklein temporarily deployed to dvc-org-pr-666 October 2, 2019 13:06 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff and long needed first step in reorganizing and consolidating tutorials, @dashohoxha - just minor comments on naming.

@shcheklein shcheklein temporarily deployed to dvc-org-pr-666 October 2, 2019 20:42 Inactive
server.js Outdated Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to dvc-org-pr-666 October 3, 2019 04:39 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-pr-666 October 3, 2019 05:30 Inactive
@jorgeorpinel
Copy link
Contributor

Hey did you check this tutorial to try to integrate it? https://medium.com/@fullstackml/aab8162f8e3f

@jorgeorpinel
Copy link
Contributor

And do you agree that this PR addresses #564?

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please pull origin/master and solve conflicts as well 🙂 (This may simplify the list of files marked as changed in the PR, making it easier to review.)

server.js Show resolved Hide resolved
src/Documentation/sidebar.json Show resolved Hide resolved
src/Documentation/sidebar.json Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to dvc-org-pr-666 October 4, 2019 06:01 Inactive
@dashohoxha
Copy link
Contributor Author

Hey did you check this tutorial to try to integrate it? https://medium.com/@fullstackml/aab8162f8e3f

It seems like a draft, but we can list it if needed. We can also do it after merging this PR.

And do you agree that this PR addresses #564?

Yes of course, at least some parts of it.

Please pull origin/master and solve conflicts as well  (This may simplify the list of files marked as changed in the PR, making it easier to review.)

I have done it once before. I did it again. But the status still shows conflicts and the button "Resolve conflicts" is inaccessible for me (grey). Can you check it, if you have access?

@shcheklein We really should try to avoid conflicts because they are more work and trouble than the patch itself.

@shcheklein shcheklein temporarily deployed to dvc-org-pr-666 October 4, 2019 06:20 Inactive
@dashohoxha
Copy link
Contributor Author

Please pull origin/master and solve conflicts as well

It seems to be fixed now.

@shcheklein
Copy link
Member

It seems like a draft, but we can list it if needed. We can also do it after merging this PR.

👍

@shcheklein We really should try to avoid conflicts because they are more work and trouble than the patch itself.

Yep, sorry about that. Not merging any refactorings before we merge this.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, @dashohoxha ! Merging this to move forward.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 4, 2019

Cool! What about the /tutorials/tutorial path? I would vote to change this to /tutorials/long but what do you think @shcheklein? And BTW should probably review old mentions of the tutorial like "Separate to this section, the longer Tutorial also introduces" in https://dvc.org/doc/get-started.

UPDATE: Actually that link isn't even working right now. It's trying to go to inexistent path /doc/tutorials/deep. Opened #676

@shcheklein
Copy link
Member

Cool! What about the /tutorials/tutorial path? I would vote to change this to /tutorials/long but what do you think @shcheklein? And BTW should probably review old mentions of the tutorial like "Separate to this section, the longer Tutorial also introduces" in https://dvc.org/doc/get-started.

👍 changed it to tutorials/deep for now. Feel free to use any other slug, I don't have a strong opinion, especially if we are going to consolidate them

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 4, 2019

That's deep.

@dashohoxha dashohoxha deleted the tutorials branch October 5, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build a "Tutorials" top-level index page
3 participants